Feature: find different Ticker data download parameters #7845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: tests with new variable
… DateTime Ranges feat: test
This reverts commit 41fa26e.
refactor: some actual changing This reverts commit 9de482b.
fix: actual changes This reverts commit 393181c.
feat: validation on ticker start with specific sign fix: option test
refactor: when resolution less hour test: new test cases + validation of SecurityType
fix: FirstTicker instead of Permtick when generate new Equity feat: validation of request Date in DownloaderDataProvider refactor: by style proj DownloaderDataProvider test:fix: starting Date in TestCases
Romazes
force-pushed
the
feature-resolve-mapped-symbol-in-data-downloader
branch
from
1b12ece
to
c1c1028
Compare
This was referenced Mar 15, 2024
Merged
Martin-Molinero
approved these changes
Mar 18, 2024
refactor: use struct instead of class
Martin-Molinero
approved these changes
Mar 18, 2024
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current system, there exists a challenge where a single ticker name can be associated with more than one company. This complicates the process of downloading historical data using Lean, as it relies solely on the ticker's name and the DateTime range to fetch data. Consequently, all data related to a requested ticker name gets saved to a single file, regardless of its association with multiple companies.
Related Issue
N/A
Motivation and Context
The primary motivation behind this PR is to enhance user experience by ensuring that users can download accurate historical data relevant to their needs. By addressing the issue of multiple companies associated with a single ticker name, we aim to provide users with the ability to access and analyze data more effectively, aligning with their specific goals and objectives.
Requires Documentation Change
N/A
How Has This Been Tested?
Extensive testing has been conducted on this PR to ensure its robustness and effectiveness. Various test cases have been meticulously designed and executed to cover a wide range of possible scenarios, including:
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>