-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for FTP notifications #8097
Merged
Martin-Molinero
merged 9 commits into
QuantConnect:master
from
jhonabreul:feature-ftp-notifications
Jun 26, 2024
Merged
Add support for FTP notifications #8097
Martin-Molinero
merged 9 commits into
QuantConnect:master
from
jhonabreul:feature-ftp-notifications
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve FTP notifications constructor and input checks.
Add public key property. Add multiple constructors and methods for FTP and SFTP notifications with either password or SSH keys. Encode file contents.
Add support for FTP notification with string contents
Martin-Molinero
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍 minor comments shared & pending prod testing
Martin-Molinero
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for sending notifications as files to FTP servers in live trading.
Related Issue
Motivation and Context
Requires Documentation Change
How Has This Been Tested?
Pushing files to test FTP servers and downloading the files to check integrity for the following cases:
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>