Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FTP notifications #8097

Merged

Conversation

jhonabreul
Copy link
Collaborator

@jhonabreul jhonabreul commented Jun 20, 2024

Description

Add support for sending notifications as files to FTP servers in live trading.

Related Issue

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Pushing files to test FTP servers and downloading the files to check integrity for the following cases:

  • FTP (unsecure) server with password.
  • SFTP server with password.
  • SFTP server with SSH key.
  • SFTP server with encrypted SSH key.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Improve FTP notifications constructor and input checks.
Add public key property.
Add multiple constructors and methods for FTP and SFTP notifications with either password or SSH keys.
Encode file contents.
Add support for FTP notification with string contents
Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍 minor comments shared & pending prod testing

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@Martin-Molinero Martin-Molinero merged commit 8bd046a into QuantConnect:master Jun 26, 2024
7 checks passed
@jhonabreul jhonabreul deleted the feature-ftp-notifications branch June 26, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants