Refactor gth_solve.py; add documentation of gth_solve and graph_tools #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oyamad Great, thanks. |
jstac
added a commit
that referenced
this pull request
Nov 23, 2014
Refactor gth_solve.py; add documentation of gth_solve and graph_tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gth_solve.py I replaced sum + list comprehension with dot + indexed arrays. The current version gets about 10% faster in some best case.
(I also corrected a typo in test_gth_solve_py.)
I realized that
gth_solveandDiGraph(in graph_tools.py) do not appear on readthedocs.To let them show up, I added graph_tools and gth_solve to docs/source/tools.rst. Do I also need to create the files "graph_tools.rst" and "gth_solve.rst"?