Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust coveragerc to skip @jit functions #303

Merged
merged 3 commits into from
Apr 19, 2017
Merged

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Apr 12, 2017

This PR adjusts the coverage rc file to adopt custom regex exclusions to make coverage statistics more useful in diagnosing code that isn't covered by tests.

This will help with PR #302

@coveralls
Copy link

Coverage Status

Coverage increased (+7.8%) to 90.805% when pulling 6792ec7 on update-lemke-howson-test into 758620a on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.4%) to 89.481% when pulling 6792ec7 on update-lemke-howson-test into 758620a on master.

@mmcky
Copy link
Contributor Author

mmcky commented Apr 12, 2017

Many @jit functions are used within a wrapper function that is tested. As long as each support jit function is tested through the parent function (either directly, or via a kwarg option) then I don't see a problem with this PR as it provides more accurate coverage statistics. It does however mean that we would need to ensure @jit(nopython=True) functions are fully tested manually.

I welcome feedback on this proposal.

A good example of this is contained in Issue #302

@oyamad
Copy link
Member

oyamad commented Apr 12, 2017

Thanks @mmcky.

The alias @njit should also be excluded.

@mmcky
Copy link
Contributor Author

mmcky commented Apr 12, 2017

Thanks @oyamad. good pickup.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.9%) to 89.889% when pulling 6cc03e9 on update-lemke-howson-test into 758620a on master.

@mmcky mmcky merged commit 10f9a84 into master Apr 19, 2017
@mmcky mmcky deleted the update-lemke-howson-test branch April 19, 2017 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants