Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add option to supply a random seed (issue #153) #346

Merged
merged 12 commits into from
Oct 5, 2017

Conversation

QBatista
Copy link
Member

Adds a random_state option to the remaining files mentioned in issue #153. I haven't added a test for lqnash.py yet -- @cc7768 did you have something in mind to add to this file?

Close #153

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.704% when pulling 23044a4 on QBatista:add_random_state into f48e7d7 on QuantEcon:master.

@oyamad
Copy link
Member

oyamad commented Sep 30, 2017

@QBatista Thanks.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 94.413% when pulling 7fcf49d on QBatista:add_random_state into f48e7d7 on QuantEcon:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.395% when pulling 0ab8e24 on QBatista:add_random_state into 21c1a94 on QuantEcon:master.

@mmcky
Copy link
Contributor

mmcky commented Oct 1, 2017

Thanks @QBatista this is looking good. I will leave this PR open a couple of days in case others wish to review / comment.

@mmcky mmcky added the ready label Oct 3, 2017
@mmcky mmcky merged commit 1558422 into QuantEcon:master Oct 5, 2017
@QBatista QBatista deleted the add_random_state branch October 8, 2017 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants