Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Use np.ix_ to extract submatrix #389

Merged
merged 1 commit into from
Feb 6, 2018
Merged

MAINT: Use np.ix_ to extract submatrix #389

merged 1 commit into from
Feb 6, 2018

Conversation

oyamad
Copy link
Member

@oyamad oyamad commented Feb 4, 2018

Replace matrix[indices, :][:, indices] with matrix[np.ix_(indices, indices)].

I happened to find this fact.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 94.91% when pulling d1d48f8 on submatrix into 2aa53f7 on master.

@oyamad oyamad added the ready label Feb 4, 2018
@mmcky
Copy link
Contributor

mmcky commented Feb 4, 2018

reference to docs: https://docs.scipy.org/doc/numpy-1.13.0/reference/generated/numpy.ix_.html

@mmcky mmcky merged commit 49ad385 into master Feb 6, 2018
@mmcky mmcky deleted the submatrix branch February 6, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oyamad @coveralls @mmcky