Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Add macOS to the build matrix #448

Merged
merged 3 commits into from
Dec 10, 2018
Merged

Travis: Add macOS to the build matrix #448

merged 3 commits into from
Dec 10, 2018

Conversation

rht
Copy link
Contributor

@rht rht commented Dec 9, 2018

This fixes #359.

@rht
Copy link
Contributor Author

rht commented Dec 9, 2018

Note: the version shipped in xcode10 is 3.7.

@rht rht force-pushed the macOS branch 2 times, most recently from 9409aba to c1f5412 Compare December 9, 2018 02:11
@coveralls
Copy link

coveralls commented Dec 9, 2018

Coverage Status

Coverage decreased (-0.03%) to 94.547% when pulling 57ba55b on rht:macOS into 6ba4ba0 on QuantEcon:master.

@rht rht force-pushed the macOS branch 3 times, most recently from 6a48534 to eea9fee Compare December 9, 2018 02:49
@rht
Copy link
Contributor Author

rht commented Dec 9, 2018

The first commit setup works fine (by install hdf5 via homebrew instead of conda), however, the machine was too slow to run the timing test. using conda is much faster

@rht rht force-pushed the macOS branch 4 times, most recently from accbdae to 109996e Compare December 9, 2018 03:58
@mmcky
Copy link
Contributor

mmcky commented Dec 9, 2018

thanks @rht -- this is great. I will check through the diff tomorrow and merge.

@rht rht force-pushed the macOS branch 2 times, most recently from c571bde to ecf400b Compare December 9, 2018 12:04
@rht
Copy link
Contributor Author

rht commented Dec 9, 2018

OK, I found the test_rotated_hyper_ellipsoid to be non-deterministic though, in that sometimes on darwin it is fulfilled/failed, in that I can't write it as a test-expect-fail.

@mmcky
Copy link
Contributor

mmcky commented Dec 10, 2018

hey @rht we have had tests running on linux for quite some time. I'm not sure why you're getting non-deterministic results. Are you sure its not just a tolerance issue?

@rht
Copy link
Contributor Author

rht commented Dec 10, 2018

Otherwise, I can't explain the error in the commit "TestTicTacToc: Skip test_loop and test_timer for darwin". There was an error of ~1e-5.

@rht
Copy link
Contributor Author

rht commented Dec 10, 2018

So, the test flake disappeared in the dust just like that.

@mmcky
Copy link
Contributor

mmcky commented Dec 10, 2018

thanks @rht for the PR! I will merge this and take a look at tic tac toc issue for darwin when I get a chance. It's tested on the linux side anyway.

@mmcky mmcky merged commit 6a14ebb into QuantEcon:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OSX to travis.yml configuration
3 participants