-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fix time errors on windows and numpy warnings #645
Conversation
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for setting a higher `rtol' for all platforms (not skipping on particular platforms).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove these parts?
QuantEcon.py/quantecon/util/tests/test_timing.py
Lines 18 to 20 in 89a7012
if platform == 'darwin': | |
# skip for darwin | |
return |
QuantEcon.py/quantecon/util/tests/test_timing.py
Lines 39 to 41 in 89a7012
if platform == 'darwin': | |
# skip for darwin | |
return |
That issue with osx is still not fixed. I tried enabling that and found these results: https://github.com/QuantEcon/QuantEcon.py/actions/runs/3374887986/jobs/5600990154:
While the expected values are Locally, this passes for me on MAC M1 but not sure why that fails on the CI. |
Just raise |
I tried to raise that and still, there seems to be a large difference.
|
Then let |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Smit-create Great, thanks!
Is there a reason it's slower and can it be fixed? |
Fixes #633
Fixes #647