-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Commit history of API changes #674
Conversation
The commit history issues seem to be resolved and it can be verified on my fork's branch: https://github.com/Smit-create/QuantEcon.py/tree/i-671/quantecon |
@@ -6,7 +6,7 @@ | |||
""" | |||
import numbers | |||
import numpy as np | |||
from ..compute_fp import _compute_fixed_point_ig | |||
from quantecon._compute_fp import _compute_fixed_point_ig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be from .._compute_fp
?
from quantecon._compute_fp import _compute_fixed_point_ig | |
from .._compute_fp import _compute_fixed_point_ig |
(Several other places.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relative imports are often confusing so IMHO it's better to use absolute imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it just a matter of exposition? I thought it made some real difference in some occasions (but I don't know what it would be).
But one general idea is that one should avoid hard coding: If we wanted to change the library name (although it is very unlikely to happen), the part would have to be modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmcky You made some argument about this in #137 (comment) (long time ago..). Would that apply here?
What is the status of this PR? We can discuss the " |
I have rebased this on the top of the latest
Please try these steps to verify and when both @oyamad and @mmcky agree we can look forward to merging this. Somehow there is some overriding to commit history because of merge conflicts and so the commit history of these files is getting lost. |
@Smit-create Can you share your script to change the file names? (I guess you didn't type commands manually one by one?) |
Renaming files using this: Python script
import subprocess
# add full path
ROOT_DIR_PATH = '/Users/thebigbool/repos/Quantecon.py/quantecon'
files = ['lae.py', 'gridtools.py', 'estspec.py', 'ivp.py',
'arma.py', 'lqnash.py',
'kalman.py', 'lqcontrol.py', 'inequality.py',
'lss.py', 'dle.py', 'matrix_eqn.py', 'discrete_rv.py',
'rank_nullspace.py', 'graph_tools.py', 'robustlq.py', 'ce_util.py',
'ecdf.py', 'filter.py', 'compute_fp.py', 'quadsums.py']
for file in files:
_file = "_" + file
cmd = f"git mv {file} {_file}"
process = subprocess.run(cmd, shell=True, cwd=ROOT_DIR_PATH)
if process.returncode != 0:
print(f"Command failed: {cmd}")
exit(1) |
Closing in favor of #682 |
Fixes #671