Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mathjax] enable chtml since v3 updated to v3.2 #179

Closed
wants to merge 6 commits into from
Closed

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 18, 2021

See if chtml can be used instead of svg for math rendering

@github-actions github-actions bot temporarily deployed to commit August 18, 2021 01:44 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Aug 18, 2021

@shlff @AakashGfude this chtml looks really nice now -- if you had 10 minutes would you mind taking a quick look at a few pages and let me know what you think.

mathjax released version 3.2 -- @AakashGfude can you confirm which mathjax version is loaded on the preview.

@mmcky
Copy link
Contributor Author

mmcky commented Aug 18, 2021

This is looking pretty good -- even handles the long equations in

https://611c65f7767a946576581014--nostalgic-wright-5fa355.netlify.app/re_with_feedback.html#fun-with-sympy-code

well.

@mmcky
Copy link
Contributor Author

mmcky commented Aug 18, 2021

@AakashGfude I think I figure it out with web inspector

e.mathjax = {
                    version: "3.2.0",

so 3.2 is loading 👍

@AakashGfude
Copy link
Member

@AakashGfude I think I figure it out with web inspector

e.mathjax = {
                    version: "3.2.0",

so 3.2 is loading 👍

Nice work @mmcky .

@shlff
Copy link
Member

shlff commented Aug 18, 2021

This is looking pretty good -- even handles the long equations in

https://611c65f7767a946576581014--nostalgic-wright-5fa355.netlify.app/re_with_feedback.html#fun-with-sympy-code

well.

Thanks @mmcky . They look nice to me.

I guess this long equation is a bit so long that we could also modify the code a bit.

Additionally I notice that the horizontal lines in a fraction and a square root are missing. Will we fix that as well? e.g., the following:
Screen Shot 2021-08-18 at 3 10 27 pm

@mmcky
Copy link
Contributor Author

mmcky commented Aug 18, 2021

@shlff nice work! I didn't see the missing horizontal lines but that is a problem still!

https://python.quantecon.org/re_with_feedback.html#fun-with-sympy-code

Might need to investigate this before we switch to chtml

amirsssss and others added 2 commits November 19, 2021 18:24
there were two iterations on variable i in nested loops, I changed one to counter
@github-actions github-actions bot temporarily deployed to commit November 19, 2021 21:39 Inactive
@github-actions github-actions bot temporarily deployed to commit November 28, 2021 23:19 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Nov 28, 2021

@AakashGfude @shlff

https://61a40e5836e4295a847bfa2f--nostalgic-wright-5fa355.netlify.app/re_with_feedback.html

these are now working with chtml so we should be able to turn svg off soon.

There are now a lot of matplotlib deprecation warnings though :-(

@shlff
Copy link
Member

shlff commented Dec 4, 2021

Thanks @mmcky . Those warnings are raised because the following four functions or class were deprecated in Matplotlib 3.4 and will be removed soon in matplotlib:

  • to_png
  • to_rgba
  • to_mask
  • MathtextBackendBitmap

I will try to search for their substitutes and see if I can remove these warnings. I will keep you posted here later.

@github-actions
Copy link

@mmcky
Copy link
Contributor Author

mmcky commented Nov 17, 2022

@jstac the font size for math in chtml seems a bit bigger than under svg. Interested in your thoughts for the inline math (in particular).

@mmcky mmcky removed the on-hold label Nov 17, 2022
@mmcky
Copy link
Contributor Author

mmcky commented Mar 22, 2023

chtml has been enabled so this is no longer required.

@shlff I have checked the test case you mentioned above and it looks nice now.

https://641a5b9009dd68246c2dc87b--nostalgic-wright-5fa355.netlify.app/re_with_feedback.html#fun-with-sympy

@mmcky mmcky closed this Mar 22, 2023
@mmcky mmcky deleted the enable-chtml branch March 22, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants