Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Undeprecate AMSS #159

Merged
merged 6 commits into from
Nov 16, 2018
Merged

Undeprecate AMSS #159

merged 6 commits into from
Nov 16, 2018

Conversation

Nosferican
Copy link
Collaborator

Needs test and check of plot change. 0.7 only for now, until Dierckx.jl tags a 1.0 compat.

Needs test and check of plot change. 0.7 only for now, until Dierckx.jl tags a 1.0 compat.
@Nosferican
Copy link
Collaborator Author

@arnavs this is ready for review.

@arnavs
Copy link
Member

arnavs commented Oct 20, 2018

Looks good, we just need to add a pkg"add Dierckx" since we took that out of the shared QuantEcon environment.

@jlperla
Copy link
Member

jlperla commented Oct 21, 2018

Is Dierckx.jl really necessary here, or could Interpolations.jl do the job? The missing feature in interpolations is splines with irregular grids, but when I did a quick look at this, it appeared the grid was regular? If it appears feasible, maybe add in a new issue for someone to convert it.

@Nosferican
Copy link
Collaborator Author

As an update... Been working on this long hours... The lecture "works" on 1.0, but is very dense and hard to follow. I have been able to make several passes improving it, but it needs at least some re-write to be "acceptable". I am also working on putting the tests before applying the re-write.

RW AMSS
@Nosferican
Copy link
Collaborator Author

That seems to be correct... Can't get the 0.6 version to run and tests were never performed on that one. It needs to be verified, but the lesson takes forever to run... Would be nice to have the Interpolations pass and merge it.

This was referenced Nov 10, 2018
@arnavs
Copy link
Member

arnavs commented Nov 16, 2018

Merging this, thanks so much @Nosferican for wrangling with this lecture.

@arnavs arnavs merged commit b51c07a into master Nov 16, 2018
This was referenced Nov 16, 2018
@arnavs arnavs deleted the Undeprecation-AMSS branch December 14, 2018 19:37
@arnavs arnavs mentioned this pull request Dec 20, 2018
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants