-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
Not sure if we want to tackle this at the moment, but in my experience some of the images should be reduced from 100% size. If that is the case in your end, you could do so now or leave it to the images pass. Other than that, it seems fine. |
Sure, and we can add that to the style guide as well (@jlperla). Something like "make sure your images take up no more than X% of screen width." |
IT is very hard for me to say right now, because images break when you move the files. But I also am on of the opinion that we should try to reorganize the files so that images not generated by the underlying jupyter are avoided where possible. |
Basically: until we see the HTML and PDF output of this, it is hard to know the right approach. |
Sounds good @jlperla. Going to merge this then and we can revisit the plots towards the end. |
Yeah, this doesn't seem to use anything too advanced that we didn't introduce in the intro slides. |
mc = MarkovChain(P) | ||
labels = ["start unemployed", "start employed"] | ||
y_vals = Array{Vector}(undef, 2) # sample paths holder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should definitely replace this with a matrix if possible.
#160. Nothing major. Just mainly:
DiscreteRV
to Bernoulli or Categorial from Distribution.