Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Rewrite "Finite Markov Chains" #173

Merged
merged 4 commits into from
Oct 18, 2018
Merged

Rewrite "Finite Markov Chains" #173

merged 4 commits into from
Oct 18, 2018

Conversation

arnavs
Copy link
Member

@arnavs arnavs commented Oct 18, 2018

#160. Nothing major. Just mainly:

  1. Moved away from QuantEcon.jl's DiscreteRV to Bernoulli or Categorial from Distribution.
  2. Made some style guide/legibility changes.

@Nosferican Nosferican mentioned this pull request Oct 18, 2018
53 tasks
@Nosferican
Copy link
Collaborator

Not sure if we want to tackle this at the moment, but in my experience some of the images should be reduced from 100% size. If that is the case in your end, you could do so now or leave it to the images pass. Other than that, it seems fine.

@arnavs
Copy link
Member Author

arnavs commented Oct 18, 2018

Sure, and we can add that to the style guide as well (@jlperla). Something like "make sure your images take up no more than X% of screen width."

@jlperla
Copy link
Member

jlperla commented Oct 18, 2018

IT is very hard for me to say right now, because images break when you move the files. But I also am on of the opinion that we should try to reorganize the files so that images not generated by the underlying jupyter are avoided where possible.

@jlperla
Copy link
Member

jlperla commented Oct 18, 2018

Basically: until we see the HTML and PDF output of this, it is hard to know the right approach.

@arnavs
Copy link
Member Author

arnavs commented Oct 18, 2018

Sounds good @jlperla. Going to merge this then and we can revisit the plots towards the end.

@arnavs arnavs merged commit 18f7004 into master Oct 18, 2018
@jlperla
Copy link
Member

jlperla commented Oct 18, 2018

Yeah, this doesn't seem to use anything too advanced that we didn't introduce in the intro slides.

mc = MarkovChain(P)
labels = ["start unemployed", "start employed"]
y_vals = Array{Vector}(undef, 2) # sample paths holder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should definitely replace this with a matrix if possible.

@arnavs arnavs deleted the rewrite-finite-markov branch December 14, 2018 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants