Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Update Julia by Example #26

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Update Julia by Example #26

merged 2 commits into from
Aug 28, 2018

Conversation

Nosferican
Copy link
Collaborator

No description provided.

@Nosferican Nosferican added this to the Update to 0.7/1.0 syntax milestone Aug 28, 2018
@Nosferican Nosferican self-assigned this Aug 28, 2018
@Nosferican Nosferican requested a review from arnavs August 28, 2018 00:32
@arnavs arnavs mentioned this pull request Aug 28, 2018
53 tasks
@arnavs
Copy link
Member

arnavs commented Aug 28, 2018

Can confirm that this is undeprecated. But I want to hold off on merging until we figure out a clean, permanent solution to the scoping issue Jesse mentioned in #39.

Additionally, I think this syntax:

using Pkg: add, installed
"Distributions" ∈ keys(installed()) || add("Distributions")

should either be explained or hidden. I think @jlperla's goal was to make these lectures similar to an Apple demo --- showing you no more than you need to get on board.

@jlperla
Copy link
Member

jlperla commented Aug 28, 2018

Yeah. I am generally loathe to use anything relying on short circuiting logic at all. It is pretty advanced for new users, and even confusing for good programmers coming from many languages.

But I suspect that code is just temporary until we have the Manifest stuff working

Copy link
Member

@arnavs arnavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed above.

@arnavs arnavs merged commit 5039a31 into master Aug 28, 2018
@arnavs arnavs deleted the Update-Julia_by_Example branch August 29, 2018 03:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants