Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Update Types and Methods #29

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Update Types and Methods #29

merged 1 commit into from
Aug 28, 2018

Conversation

Nosferican
Copy link
Collaborator

  • Made a small change to fix an issue in the material
  • We could add something about constructors eventually

- Made a small change to fix an issue in the material
- We could add something about constructors eventually
@Nosferican Nosferican added this to the Update to 0.7/1.0 syntax milestone Aug 28, 2018
@Nosferican Nosferican self-assigned this Aug 28, 2018
@Nosferican Nosferican requested a review from arnavs August 28, 2018 05:10
@arnavs arnavs mentioned this pull request Aug 28, 2018
53 tasks
Copy link
Member

@arnavs arnavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues here.

@@ -495,14 +447,13 @@ If the interpreter can't find a match in immediate parents (supertypes) it proce

* If not, we get an error

This is the process that leads to the following error
This is the process that leads to the following error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't yield the desired error, because this block inherits +(x::Integer, y::String) from an earlier code block. Will eventually need to replace with a valid example.

@@ -745,7 +672,6 @@ For the distribution ``ϕ`` we'll assign a ``Distribution`` from the `Distributi
m = AR1(0.9, 1, 1, Beta(5, 5))



In this call to the constructor we've created an instance of ``AR1`` and bound the name ``m`` to it

We can access the fields of ``m`` using their names and "dotted attribute" notation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably put something in here eventually about how direct access is a bad idea.

@arnavs arnavs merged commit cedc54e into master Aug 28, 2018
@arnavs arnavs deleted the Update_Types_and_Methods branch August 29, 2018 03:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants