Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

optgrowth.rst: PyPlot.jl converted to Plots.jl #84

Merged
merged 1 commit into from
Sep 13, 2018

Conversation

ajozefiak
Copy link
Member

No description provided.

@arnavs
Copy link
Member

arnavs commented Sep 13, 2018

Thanks @ajozefiak, this looks great. Few comments:

  1. Going forward, it would be great if you could target this backend specifically (https://github.com/JuliaPlots/PlotsGR.jl), since that's what we'll be using. See below for this.

  2. No need to try and match the LaTeX strings in the labels, titles, etc., since we'll be ripping those out.

  3. There's some weird issue where our true and approximate value functions seem to be switched. I played around and I don't think this is a result of what you did (i.e., our approximate value function is genuinely below our true one). So I'll merge, but will post an issue.

screen shot 2018-09-13 at 10 17 33 am

@arnavs arnavs merged commit de3f9ce into QuantEcon:master Sep 13, 2018
@arnavs
Copy link
Member

arnavs commented Sep 13, 2018

Actually, scratch that re GR. It is the backend we're using, but since it's baked into Plots.jl, there's no reason to do anything special for it.

And cc @Nosferican for the thing above. I'll confirm that the math is the same, in which case maybe it's due to something like shock stochasticity.

@ajozefiak
Copy link
Member Author

Do you want me to completely disregard LaTeX strings? I can include them, the only issue was variable interpolation going from PyPlot to Plots.

@jlperla
Copy link
Member

jlperla commented Sep 13, 2018

Yeah, I think so. We are going to have to go through a pass on all of the plots to get rid of the latex labels at some point in the near future, so if you strip out some of them it can't hurt. Sadly, unicode won't work well either in plot labels/titles (though it is great in the rest of the notes), so keep the labels as relatively simple text for now.

We can discuss the issues with unicode and latex issues in person sometime, but it is a fragile setup problem for many users.

@Nosferican Nosferican mentioned this pull request Sep 26, 2018
20 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants