Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

UPDATE: adjust structure for new python.quantecon.org bucket #683

Merged
merged 40 commits into from
Oct 1, 2019

Conversation

mmcky
Copy link
Collaborator

@mmcky mmcky commented Sep 17, 2019

This PR makes adjustments for the new python.quantecon.org s3 bucket structure.

Tasks:

  • add new landing page
  • add about_lectures.rst page
  • populate about_lectures.rst (@jstac)
  • adopt a new custom python theme. (@DrDrij working on python-html.tpl)
  • updates to Makefile for new theme
  • migrate new theme to private theme and adopt default editing theme in this repo

Cleaning:

  • @DrDrij to clean up the theme folder of any unused assets.

@mmcky mmcky added the in-work label Sep 17, 2019
@mmcky
Copy link
Collaborator Author

mmcky commented Sep 18, 2019

@DrDrij in the new template it would be nice if we could have an easy to enable announcements panel. Perhaps under the breadcrumbs that we could post short term information.

image

@mmcky
Copy link
Collaborator Author

mmcky commented Sep 19, 2019

  • @DrDrij we will need to address these on this branch. I am happy to make the changes when you're ok with a pull/push
/home/ubuntu/repos/lecture-source-py/source/rst/404.rst:3: WARNING: Title overline too short.

**********
Page Not Found
**********
looking for now-outdated files... none found
pickling environment... done
checking consistency... /home/ubuntu/repos/lecture-source-py/source/rst/404.rst: WARNING: document isn't included in any toctree
/home/ubuntu/repos/lecture-source-py/source/rst/search.rst: WARNING: document isn't included in any toctree
/home/ubuntu/repos/lecture-source-py/source/rst/status.rst: WARNING: document isn't included in any toctree

@mmcky
Copy link
Collaborator Author

mmcky commented Sep 19, 2019

  • pdf construction using make pdf and ipynb_pdf_constructor doesn't seem to be working for this branch. (@mmcky) and gets stuck on about_lectures.

This is now working. Lecture need to have a .. contents toc for ipynb_pdf_constructor to not fail.

@mmcky
Copy link
Collaborator Author

mmcky commented Sep 19, 2019

Fix the next round of sphinx warnings

/home/ubuntu/repos/lecture-source-py/source/rst/index_toc.rst:61: WARNING: Explicit markup ends without a blank line; unexpected unindent.
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] zreferences                                                                                                                                                                                                          
/home/ubuntu/repos/lecture-source-py/source/rst/index.rst:: WARNING: Invalid jupyter kernels. jupyter_kernels: {'python3': {'kernelspec': {'display_name': 'Python', 'language': 'python3', 'name': 'python3'}, 'file_extension': '.py'}}, lang: python3

@mmcky
Copy link
Collaborator Author

mmcky commented Sep 19, 2019

User Testing Results:

  • execution badge links from status.html page link to py folder context and 404
  • execution test badge on index pages should show total execution stats (% passing) on status.html and pass/fail on all lecture pages

image

  • @DrDrij should execution badge be right aligned as in the picture above?

  • troubleshooting needs to be setup (@mmcky) fa5c28b

  • Report Issue needs to be setup (@mmcky) -- investigate if issue template can be used in lecture-source-py. No going to bother with templates

  • Add Report Issue link to https://github.com/QuantEcon/lecture-source-py/issues @DrDrij

  • there are no breadcrumbs on https://preview.python.quantecon.org/index_toc.html

  • Alternative lecture listings for undergrad and grad courses are still linked to py folder context https://preview.python.quantecon.org/py/index_undergrad.html

  • homepage meta-title needs fixing (@DrDrij)

  • tidy up undergrad and grad index pages

Screen Shot 2019-09-19 at 4 29 14 pm

@mmcky
Copy link
Collaborator Author

mmcky commented Sep 20, 2019

  • pdf construction of 404 halts ipynb_pdf_constructor. @AakashGfude perhaps we should add a simple file filter for these types of documents for ipynb_pdf_constructor

@mmcky
Copy link
Collaborator Author

mmcky commented Sep 23, 2019

@mmcky mmcky requested a review from DrDrij September 30, 2019 23:40
@mmcky mmcky removed the in-work label Oct 1, 2019
Copy link
Member

@DrDrij DrDrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock and roll.

@mmcky mmcky merged commit 59eb45f into master Oct 1, 2019
@mmcky mmcky deleted the standalone-bucket branch November 10, 2019 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants