Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic site visual updates #92

Merged
merged 3 commits into from
May 28, 2023
Merged

Basic site visual updates #92

merged 3 commits into from
May 28, 2023

Conversation

DrDrij
Copy link
Member

@DrDrij DrDrij commented May 24, 2023

  1. "down arrow" should be a bit larger and more visible
  2. "About" and "Team" pages can be merged, reducing links on top right.
  3. Books need higher visibility

The books are https://dp.quantecon.org/ and https://networks.quantecon.org/

@DrDrij
Copy link
Member Author

DrDrij commented May 24, 2023 •
edited
Loading

  • Increased hero arrow size
  • Moved team onto about page
  • Removed old notebooks page

Higher visibility for books will go into a new issue #94

@DrDrij DrDrij requested a review from mmcky May 24, 2023 04:59
@DrDrij
Copy link
Member Author

DrDrij commented May 24, 2023

@mmcky sorry for my lack of GH etiquette, simple fixes here just need a reviewer please :)

@mmcky
Copy link
Collaborator

mmcky commented May 25, 2023 •
edited
Loading

doesn't look like there are preview builds on this repo. Thanks for this @DrDrij. Please go ahead and merge when you're ready. :-)

mmcky
mmcky approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DrDrij look forward to seeing the improvements when it is live.

@DrDrij DrDrij merged commit 1d1ac16 into master May 28, 2023
4 checks passed
@mmcky mmcky deleted the updates-may branch May 30, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DrDrij @mmcky