-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create YaoTreeToPastaQList.jl #1
Conversation
we use snake case for file names except the module file. for this package, it should be simple enough to just put code inside |
1 similar comment
we use snake case for file names except the module file. for this package, it should be simple enough to just put code inside |
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
===========================================
+ Coverage 0 78.94% +78.94%
===========================================
Files 0 1 +1
Lines 0 38 +38
===========================================
+ Hits 0 30 +30
- Misses 0 8 +8
Continue to review full report at Codecov.
|
Added more gates
@Roger-luo thats most of the gates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still far from finish, you still need:
- make a PastaQ regsiter
- write tests to get over 90% test coverage
@Roger-luo Okay, kindly review it once more. I'll start writing the tests if its okay this far |
@VarLad you didn't implement the register type. please do a you are not following the style guide, code inside module shouldn't have indent |
please add tests first before asking for review |
Sorry, I saw this 😅
I'll remove the indentation |
@Roger-luo If this is all correct, I guess what remains is to write the register..... |
looks good in general, we can merge this PR after change the above two coments. then you can open a new PR for the register |
Okay, now the registers.... |
Covered most of the gates, except for
iSWAP, Rn, sqrt(X), CRn, and sqrt(SWAP) gates