Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

[WIP] Switch to Luxor backend #56

Merged
merged 9 commits into from
Jun 18, 2022
Merged

[WIP] Switch to Luxor backend #56

merged 9 commits into from
Jun 18, 2022

Conversation

GiggleLiu
Copy link
Member

@GiggleLiu GiggleLiu commented Jun 17, 2022

Does it look better? @Roger-luo

NOTE: the using time is increased a bit because ZX visualization still requires Compose backend.
Maybe we can consider moving YaoPlots to Yao. If we do so, the using time change is:

julia> @time using YaoPlots, Yao  # Luxor backend
  2.702133 seconds (8.88 M allocations: 602.516 MiB, 3.48% gc time, 11.90% compilation time)

compared to

julia> @time using Yao
  2.072055 seconds (7.59 M allocations: 519.156 MiB, 1.30% gc time, 14.47% compilation time)

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #56 (14ff467) into master (f553a60) will increase coverage by 30.11%.
The diff coverage is 81.08%.

@@             Coverage Diff             @@
##           master      #56       +/-   ##
===========================================
+ Coverage   50.75%   80.87%   +30.11%     
===========================================
  Files           4        3        -1     
  Lines         329      298       -31     
===========================================
+ Hits          167      241       +74     
+ Misses        162       57      -105     
Impacted Files Coverage Δ
src/vizcircuit.jl 80.42% <80.70%> (+13.17%) ⬆️
src/YaoPlots.jl 50.00% <100.00%> (+50.00%) ⬆️
src/helperblock.jl 93.33% <100.00%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c63278...14ff467. Read the comment docs.

@GiggleLiu GiggleLiu changed the title Switch to Luxor backend [WIP] Switch to Luxor backend Jun 17, 2022
@GiggleLiu GiggleLiu requested review from ChenZhao44 and Roger-luo and removed request for ChenZhao44 June 18, 2022 20:26
@GiggleLiu GiggleLiu merged commit 67a79c2 into master Jun 18, 2022
@GiggleLiu GiggleLiu deleted the luxor branch June 18, 2022 20:50
@ChenZhao44
Copy link
Member

I'm considering moving ZX visualization part to ZXCalculus.jl. I will also look into the new backend.

@GiggleLiu
Copy link
Member Author

https://github.com/GiggleLiu/LuxorGraphPlot.jl

Luxor is more actively maintained. This is a frontend that I built for replacing GraphPlot.jl

@GiggleLiu GiggleLiu restored the luxor branch September 22, 2022 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants