pmd: enable some basic and optimizations rules

QuantumBadger · Dec 3, 2016 · d5a04a8 · d5a04a8
1 parent 9ed878c
commit d5a04a8
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/config/pmd/rules.xml b/config/pmd/rules.xml
@@ -5,6 +5,11 @@
         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
         xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
 
+    <rule ref="rulesets/java/basic.xml">
+        <exclude name="CollapsibleIfStatements"/> <!--sometimes forces hard to read code-->
+        <exclude name="AvoidUsingHardCodedIP"/>
+        <exclude name="SimplifiedTernary"/>
+    </rule>
     <rule ref="rulesets/java/imports.xml" />
     <rule ref="rulesets/java/unusedcode.xml/UnusedLocalVariable"/>
     <rule ref="rulesets/java/android.xml"/>
@@ -14,6 +19,10 @@
         <exclude name="UselessParentheses"/> <!--Too nitpicky-->
     </rule>
 
+    <rule ref="rulesets/java/optimizations.xml/AddEmptyString"/>
+    <rule ref="rulesets/java/optimizations.xml/UseArraysAsList"/>
+    <rule ref="rulesets/java/optimizations.xml/UnnecessaryWrapperObjectCreation"/>
+
     <rule ref="rulesets/java/design.xml/FinalFieldCouldBeStatic"/>
     <rule ref="rulesets/java/design.xml/CloseResource"/>
     <rule ref="rulesets/java/design.xml/SimplifyBooleanExpressions"/>