Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface code #246

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Surface code #246

merged 10 commits into from
Mar 27, 2024

Conversation

royess
Copy link
Contributor

@royess royess commented Mar 22, 2024

The PR adds surface codes, which are tailored toric codes that require less boundary connectivity,

  • Implement surface codes based on existing toric code implementation.
  • Implement a specially tailored 9-qubit surface code.
  • Improve the docstrings for the toric code and add its reference paper.

@royess
Copy link
Contributor Author

royess commented Mar 22, 2024

I have fixed an overwrite bug; now, most CI tasks are passed. I noticed some failures, but they seem to be unrelated to this PR.

@Krastanov, could you help review this PR? Thanks!

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great!

src/ecc/codes/toric.jl Show resolved Hide resolved
src/ecc/codes/surface.jl Outdated Show resolved Hide resolved
src/ecc/codes/surface.jl Outdated Show resolved Hide resolved
test/test_ecc_decoder_all_setups.jl Show resolved Hide resolved
@royess royess requested a review from Krastanov March 23, 2024 12:57
@Krastanov
Copy link
Member

  • Let's stick to the name "Surface".
  • If the 9-qubit example you have is simply an instance of the rotated surface code, let's delete it -- no need to have a single instance of a family without having the family.

docs/src/references.bib Outdated Show resolved Hide resolved
@royess
Copy link
Contributor Author

royess commented Mar 26, 2024

Thanks for your suggestions! The new commit removed the 9-qubit (rotated) Surface code and did the aforementioned formatting.

@royess royess requested a review from Krastanov March 26, 2024 08:26
Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I made some minor style suggestions and a request to plug the code example docs into the test runner, but otherwise this is good to merge.

src/ecc/codes/toric.jl Outdated Show resolved Hide resolved
src/ecc/codes/surface.jl Outdated Show resolved Hide resolved
src/ecc/codes/toric.jl Outdated Show resolved Hide resolved
src/ecc/codes/surface.jl Outdated Show resolved Hide resolved
src/ecc/codes/surface.jl Outdated Show resolved Hide resolved
src/ecc/codes/surface.jl Outdated Show resolved Hide resolved
src/ecc/codes/surface.jl Outdated Show resolved Hide resolved
src/ecc/codes/toric.jl Outdated Show resolved Hide resolved
royess and others added 2 commits March 27, 2024 09:42
Co-authored-by: Stefan Krastanov <github.acc@krastanov.org>
@royess royess requested a review from Krastanov March 27, 2024 02:11
@Krastanov Krastanov merged commit e051bd1 into QuantumSavory:master Mar 27, 2024
9 of 13 checks passed
@royess royess deleted the surface branch March 27, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants