New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to whitelist #10
Conversation
Follow https://www.qubes-os.org/doc/coding-style/ No functional change, diff -w is empty.
Whitelist options: -R --hidden-encrypt-to --try-secret-key --try-all-secrets --skip-hidden-recipients --no-skip-hidden-recipients Fixes QubesOS/qubes-issues#2939
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only suggestion is to add two more options that allows to change all recipients into hidden-recipient (or to disable it, if enabled in the config file).
throw-keyids
no-throw-keyids
src/gpg-common.h
Outdated
@@ -213,6 +224,7 @@ static const struct option gpg_long_options[] = { | |||
{"no-force-v4-certs", 0, 0, opt_no_force_v4_certs}, | |||
{"no-greeting", 0, 0, opt_no_greeting}, | |||
{"no-secmem-warning", 0, 0, opt_no_secmem_warning}, | |||
{"no-skip-hidden-recipients", 0, 0, opt_no_skip_hidden_recipients}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add {"no-throw-keyids", 0, 0, opt_no_throw_keyids},
src/gpg-common.h
Outdated
@@ -237,11 +249,14 @@ static const struct option gpg_long_options[] = { | |||
{"s2k-digest-algo", 0, 0, opt_s2k_digest_algo}, | |||
{"s2k-mode", 0, 0, opt_s2k_mode}, | |||
{"sign", 0, 0, 's'}, | |||
{"skip-hidden-recipients", 0, 0, opt_skip_hidden_recipients}, | |||
{"status-fd", 1, 0, opt_status_fd}, | |||
{"store", 0, 0, opt_store}, | |||
{"symmetric", 0, 0, 'c'}, | |||
{"textmode", 0, 0, 't'}, | |||
{"trust-model", 1, 0, opt_trust_model}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And {"throw-keyids", 0, 0, opt_throw_keyids},
Thanks @eduncan911 for spotting this.
Fixes QubesOS/qubes-issues#2582
Fixes QubesOS/qubes-issues#2939