Skip to content

Commit

Permalink
Avoid stopping qubes-network-uplink@eth0.service
Browse files Browse the repository at this point in the history
This is already started by qubes-network-uplink.service, so stopping it
is a bad idea.  Since setup-ip is not idempotent, the result is a down
network interface.

Fixes: QubesOS/qubes-issues#8362
Fixes: QubesOS/qubes-issues#8305
  • Loading branch information
DemiMarie committed Jul 17, 2023
1 parent 21518b8 commit 5bc07d4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions network/udev-qubes-network.rules
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# new udev has DRIVERS
SUBSYSTEMS=="xen", KERNEL=="eth*", ACTION=="add", DRIVERS=="vif", RUN+="/usr/bin/systemctl restart --job-mode=replace qubes-network-uplink@%k.service", GOTO="QUBES-NET-END"
SUBSYSTEMS=="xen", KERNEL=="eth*", ACTION=="add", DRIVERS=="vif", RUN+="/usr/bin/systemctl start --job-mode=replace qubes-network-uplink@%k.service", GOTO="QUBES-NET-END"
SUBSYSTEMS=="xen", KERNEL=="eth*", ACTION=="remove", DRIVERS=="vif", RUN+="/usr/bin/systemctl stop --job-mode=replace qubes-network-uplink@%k.service", GOTO="QUBES-NET-END"
# old udev has ENV{NET_ID_DRIVER}
SUBSYSTEMS=="xen", KERNEL=="eth*", ACTION=="add", ENV{NET_ID_DRIVER}=="vif", RUN+="/usr/bin/systemctl restart --job-mode=replace qubes-network-uplink@%k.service", GOTO="QUBES-NET-END"
SUBSYSTEMS=="xen", KERNEL=="eth*", ACTION=="add", ENV{NET_ID_DRIVER}=="vif", RUN+="/usr/bin/systemctl start --job-mode=replace qubes-network-uplink@%k.service", GOTO="QUBES-NET-END"
SUBSYSTEMS=="xen", KERNEL=="eth*", ACTION=="remove", ENV{NET_ID_DRIVER}=="vif", RUN+="/usr/bin/systemctl stop --job-mode=replace qubes-network-uplink@%k.service", GOTO="QUBES-NET-END"

LABEL="QUBES-NET-END"

0 comments on commit 5bc07d4

Please sign in to comment.