Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoD] Suspend/resume troubleshooting #1053

Merged
merged 7 commits into from
Oct 19, 2020

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Oct 10, 2020

I renamed "Wireless Troubleshooting" to "Suspend/Resume Troubleshooting" and added more content to it.

@enjeck enjeck changed the title [GSoD] Resume/suspend troubleshooting [GSoD] Suspend/resume troubleshooting Oct 10, 2020
@andrewdavidwong
Copy link
Member

@PROTechThor: FYI, if you notice a failing Travis CI check, you can click "Details," then "View more details on Travis CI" at the bottom, then scroll all the way to the bottom of the (long) log, and it will show you what caused the failures. (I don't know why they make it so hard to find.) In this case, the relevant portion is:

The following new unknown spellings were introduced:
    +hyperthreading
    +wirele
In addition, the following suspicious spellings were eliminated:
    -suspendi
The introduced suspects in context are:
./_doc/user/troubleshooting/resume-suspend-troubleshooting.md:124:To solve the problem, disable hyperthreading in the BIOS. This [external guide](https://www.pcmag.com/news/how-to-disable-hyperthreading) explains how to disable hyperthreading. 
./_doc/user/troubleshooting/resume-suspend-troubleshooting.md:125:Since Qubes does disable hyperthreading by default (by not using secondary threads), you won't pay any performance cost.
+all_ok=false
+echo
+htmlproofer ./_site --disable-external --checks-to-ignore ImageCheck --file-ignore ./_site/video-tours/index.html --only_4xx --url-ignore /qubes-issues/
Running ["ScriptCheck", "LinkCheck"] on ["./_site"] on *.html... 
Ran on 1006 files!
- ./_site/doc/index.html
  *  internally linking to /doc/installation-troubleshooting/, which does not exist (line 331)
     <a href="/doc/installation-troubleshooting/">Installation Troubleshooting</a>
htmlproofer 3.16.0 | Error:  HTML-Proofer found 1 failure!

I can't find the instance of wirele, so I'm not sure what to make of that. hyperthreading is ok, but technically it should be hyper-threading. The real problem is the broken link. Would you mind fixing that up before we merge this?

@enjeck
Copy link
Contributor Author

enjeck commented Oct 11, 2020

I can't find the instance of wirele, so I'm not sure what to make of that. hyperthreading is ok, but technically it should be hyper-threading. The real problem is the broken link. Would you mind fixing that up before we merge this?

@andrewdavidwong
All fixed! Thanks for mentioning. I did see the broken link, but I assumed the Installation Troubleshooting will be merged before this, and the link will eventually exist :D

@andrewdavidwong
Copy link
Member

All fixed! Thanks for mentioning. I did see the broken link, but I assumed the Installation Troubleshooting will be merged before this, and the link will eventually exist :D

Ohh, I see. As Marek mentioned, we usually try to keep PRs independent of each other so that they can be merged in any order, or at least so that merging one doesn't cause any problems (e.g. merge conflicts) in others.

However, since you've already got all these PRs open, I would be happy to merge them in whichever order would make things easiest for you. Would that just be the order in which they were opened?

@enjeck
Copy link
Contributor Author

enjeck commented Oct 11, 2020

However, since you've already got all these PRs open, I would be happy to merge them in whichever order would make things easiest for you. Would that just be the order in which they were opened?

Yes, in that order. If any conflicts arise, I'll resolve them somehow.

@andrewdavidwong
Copy link
Member

@PROTechThor, ready for you to resolve merge conflicts on this one now.

@enjeck
Copy link
Contributor Author

enjeck commented Oct 14, 2020

@andrewdavidwong

@enjeck
Copy link
Contributor Author

enjeck commented Oct 15, 2020

@marmarek
Can you please review my latest commit?

## Attached devices in HVM stop working on suspend/resume ##

After the whole system gets suspended into S3 sleep and subsequently resumed, some attached devices may stop working. To make the devices work, they should be restarted within the VM.
This can be achieved under a Windows HVM by opening the Device Manager, selecting the actual device (such as a USB controller), 'Disabling' the device, and then 'Enabling' the device again.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this solution is specific to Windows, add "Windows HVM" to the section header.

@andrewdavidwong andrewdavidwong merged commit 460aa29 into QubesOS:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants