Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Qubes source code copyright / licensing declaration, machine readable copyright, use SPDX License Identifier #6500

Open
adrelanos opened this issue Mar 30, 2021 · 3 comments
Labels
C: other legal This issue involves matters of law. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. project management This issue pertains to the management of the Qubes OS Project. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@adrelanos
Copy link
Member

There are various issues with Qubes source code licensing declaration.

  • Each source file needs a copyright header. I've asked FSF about that ~9 years ago by private e-mail and they said yes. Nowadays FSFE is recommending the same. Also GPL-2 license file is saying that. [1]
  • rpm_spec/package-name.spec(.in) is using License: GPL instead of License: GPLv2+.
  • Each file debian/copyright must be duplicated to file COPYRIGHT in repository root file.
    (I'd suggest having a test that makes sure that these files always match.)
    (Must not be a symlink.)

https://www.qubes-os.org/doc/license/ is not defining the copyright for each Qubes source file either. It says nothing about the source code for repositories by Qubes.

No need to take my word for it. You could try e-mailing licensing@fsf.org (was helpful for me years ago) for confirmation or see https://reuse.software/ by FSFE.


On Debian, for Debian packages the linter tool lintian --pedantic is helpful to identify source code licensing / not machine readable issues.


[1] Quote GPLv2 license:

(File /usr/share/common-licenses/GPL-2 on Debian systems.)

            How to Apply These Terms to Your New Programs

  If you develop a new program, and you want it to be of the greatest
possible use to the public, the best way to achieve this is to make it
free software which everyone can redistribute and change under these terms.

  To do so, attach the following notices to the program.  It is safest
to attach them to the start of each source file to most effectively
convey the exclusion of warranty; and each file should have at least
the "copyright" line and a pointer to where the full notice is found.
@adrelanos adrelanos added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Mar 30, 2021
@andrewdavidwong andrewdavidwong added business This issue pertains to some business aspect of the Qubes OS Project. C: doc labels Mar 30, 2021
@andrewdavidwong andrewdavidwong added this to the Ongoing milestone Mar 30, 2021
@andrewdavidwong
Copy link
Member

CC @mfc

@adrelanos
Copy link
Member Author

Created QubesOS/qubes-doc#1145 as a stopgap to clarify licensing just now.

Changed:

Qubes is a compilation of software packages, each under its own license. The compilation is made available under the GNU General Public License version 2.

to:

Qubes OS is a compilation of software packages, each under its own license. The compilation is made available under the GNU General Public License version 2.

Did that for consitency because the title above said Qubes OS. Since this is legally important, it should be consistent. Otherwise Qubes and Qubes OS could be something different, unless defined.

Added:

The source code of Qubes OS (all repositories listed on the @QubesOS account on github) is made available under the same license, unless a file LICENSE in the root of the repoistory specifies a different license.

Did that because some repositories have a LICENSE file. qubes-core-admin's LICENSE file specifies a different license, LGPG v2.1. Most repositories don't have a LICENSE file.

License clarification on the website is a good stopgap since updating at time of writing 151 repositories would be quite some work, even if just adding a LICENSE file. Let alone other things mentioned in the original issue post.

@mfc
Copy link
Member

mfc commented Jun 30, 2021

shall we apply to this to get help?

https://reuse.software/booster/

@andrewdavidwong andrewdavidwong added C: other project management This issue pertains to the management of the Qubes OS Project. legal This issue involves matters of law. and removed C: doc business This issue pertains to some business aspect of the Qubes OS Project. labels May 21, 2022
@andrewdavidwong andrewdavidwong removed this from the Non-release milestone Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: other legal This issue involves matters of law. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. project management This issue pertains to the management of the Qubes OS Project. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

3 participants