Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.2-RC3: Qubes Application Menu isn't updated when using salt to modify menu-items #8494

Closed
rapenne-s opened this issue Sep 5, 2023 · 13 comments · Fixed by QubesOS/qubes-desktop-linux-common#60
Closed

4.2-RC3: Qubes Application Menu isn't updated when using salt to modify menu-items #8494

rapenne-s opened this issue Sep 5, 2023 · 13 comments · Fixed by QubesOS/qubes-desktop-linux-common#60
Assignees
@marmarta
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: app menu The primary user-facing GUI application menu in Qubes OS C: desktop-linux C: manager/widget C: mgmt diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.2

Comments

@rapenne-s
Copy link

How to file a helpful issue

Qubes OS release

4.2-RC3

Brief summary

If you update a qube menu-items settings using salt, in the qube settings in the Applications tab, you can see the new list, but this doesn't show up in the new XFCE Qubes OS menu. Making a change in that list from the GUI correctly update the new menu though.

Steps to reproduce

Make a salt state updating the menu items of a qube

create-qubes-xmpp:
  qvm.vm:
    - name: XMPP
    - present:
      - template: fedora-38
      - label: yellow
    - prefs:
      - label: yellow
    - features:
      - set:
        - menu-items: org.gnome.Terminal.desktop org.gnome.Nautilus.desktop im.dino.Dino.desktop

Use qubesctl state.apply to apply changes, it will report a success.

Expected behavior

The menu items appear in the Qubes Application menu, and in the qube settings.

Actual behavior

The menu items only appear in the qubes settings, not in the Qubes Application menu.
@rapenne-s rapenne-s added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Sep 5, 2023
@andrewdavidwong andrewdavidwong added C: mgmt needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. C: app menu The primary user-facing GUI application menu in Qubes OS affects-4.2 This issue affects Qubes OS 4.2. labels Sep 5, 2023
marmarta added a commit to marmarta/qubes-manager that referenced this issue Sep 18, 2023
@marmarta
Set menu-items feature instead of running qvm-appmenus
01f7ec0 
Make it so that vm settings set menu-items feature
instead of running qvm-appmenus

references QubesOS/qubes-issues#8494
@marmarta marmarta mentioned this issue Sep 18, 2023
Merged
@marmarek marmarek mentioned this issue Sep 18, 2023
Merged
@Rudd-O
Copy link

Rudd-O commented Sep 19, 2023

- menu-items: org.gnome.Terminal.desktop org.gnome.Nautilus.desktop im.dino.Dino.desktop

FYI @marmarek this should also accept a list, not just a string with elements separated by spaces.

marmarta added a commit to marmarta/qubes-manager that referenced this issue Sep 19, 2023
@marmarta
Set menu-items feature instead of running qvm-appmenus
50d6302 
Make it so that vm settings set menu-items feature
instead of running qvm-appmenus

references QubesOS/qubes-issues#8494
@andrewdavidwong andrewdavidwong added C: desktop-linux diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. C: manager/widget and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Sep 19, 2023
marmarta added a commit to marmarta/qubes-manager that referenced this issue Sep 19, 2023
@marmarta
Set menu-items feature instead of running qvm-appmenus
07b7647 
Make it so that vm settings set menu-items feature
instead of running qvm-appmenus

references QubesOS/qubes-issues#8494
Closed
@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Oct 8, 2023
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marmarta marmarta

Labels
affects-4.2 This issue affects Qubes OS 4.2. C: app menu The primary user-facing GUI application menu in Qubes OS C: desktop-linux C: manager/widget C: mgmt diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.2
Development

Successfully merging a pull request may close this issue.

A bunch of fixes to appmenus handling with GUI VM marmarek/qubes-desktop-linux-common
5 participants
@rapenne-s @Rudd-O @marmarta @andrewdavidwong @qubesos-bot