A bunch of fixes to appmenus handling with GUI VM #60
Conversation
It is already called on various different occasions, but menu-items change was missing. Fixes QubesOS/qubes-issues#8494
marmarek
force-pushed
the
menu-items
branch
from
028eaef
to
d52c6f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 62.66% 62.53% -0.14%
==========================================
Files 2 2
Lines 667 670 +3
==========================================
+ Hits 418 419 +1
- Misses 249 251 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Add two new qrexec services: qubes.UpdateAppmenusFor and qubes.RemoveAppmenusFor. When menu-relevant properties are changed on a VM, call qvm-appmenus via those new services, instead of directly. This gives a bit nicer interface when calling it in GUI VM that is not dom0 - which is a feature added here at the same time. This also unifies create/update calls - now update will also initialize directory structure if it wasn't there before. Fixes QubesOS/qubes-issues#8528
VM settings (including apps to include in the menu) can be changed when GUI VM is not running. In that case, queue menu update for when GUI VM is next started, instead of just logging a warning Related to QubesOS/qubes-issues#5804
When cloning a template, the menu-items may be already set by qvm-clone, do not override it. Fixes QubesOS/qubes-issues#8518
marmarek
force-pushed
the
menu-items
branch
from
d52c6f7
to
fdcbb35
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023100604-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023071104-4.2&flavor=update
Failed tests28 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/77326#dependencies 23 fixed
Unstable tests
|
Fixes QubesOS/qubes-issues#8494
Fixes QubesOS/qubes-issues#8528
QubesOS/qubes-issues#5804