Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of menu items in GUI VM #8528

Closed
marmarek opened this issue Sep 18, 2023 · 13 comments · Fixed by QubesOS/qubes-desktop-linux-common#60
Closed

Fix handling of menu items in GUI VM #8528

marmarek opened this issue Sep 18, 2023 · 13 comments · Fixed by QubesOS/qubes-desktop-linux-common#60
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: app menu The primary user-facing GUI application menu in Qubes OS C: gui-domain diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.2

Comments

@marmarek
Copy link
Member

How to file a helpful issue

Qubes OS release

R4.2

Brief summary

When creating qube with non-dom0 GUI VM, its menu entries are not created properly

Steps to reproduce

  1. Create GUI VM
  2. Set default_guivm to non-dom0
  3. Create new qube
  4. Check applications menu

Similar problem happens on changing qube label, settings disposable template flag and few other menu-affecting settings.

Expected behavior

Menu items are updated automatically.

Actual behavior

In some cases they are updated (if change is made via qube settings started in GUI VM itself), but in others not. Manual call to qvm-appmenus --update is necessary. In any case, desktop files are created in dom0.
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: gui-domain P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Sep 18, 2023
@marmarek marmarek mentioned this issue Sep 18, 2023
Closed
6 tasks
@marmarek
Copy link
Member Author

This is also related to #5804

marmarek added a commit to marmarek/qubes-desktop-linux-common that referenced this issue Sep 18, 2023
@marmarek
appmenus: Call qvm-appmenus via qrexec service
559de3e 
Add two new qrexec services: qubes.UpdateAppmenusFor and qubes.RemoveAppmenusFor.
When menu-relevant properties are changed on a VM, call qvm-appmenus via
those new services, instead of directly. This gives a bit nicer
interface when calling it in GUI VM that is not dom0 - which is a
feature added here at the same time.

Fixes QubesOS/qubes-issues#8528
@marmarek marmarek mentioned this issue Sep 18, 2023
Merged
marmarek added a commit to marmarek/qubes-desktop-linux-common that referenced this issue Sep 18, 2023
@marmarek
appmenus: Call qvm-appmenus via qrexec service
f1964f9 
Add two new qrexec services: qubes.UpdateAppmenusFor and qubes.RemoveAppmenusFor.
When menu-relevant properties are changed on a VM, call qvm-appmenus via
those new services, instead of directly. This gives a bit nicer
interface when calling it in GUI VM that is not dom0 - which is a
feature added here at the same time.

Fixes QubesOS/qubes-issues#8528
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. affects-4.2 This issue affects Qubes OS 4.2. C: app menu The primary user-facing GUI application menu in Qubes OS labels Sep 19, 2023
@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Oct 8, 2023
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package desktop-linux-common has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component desktop-linux-common (including package desktop-linux-common) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: app menu The primary user-facing GUI application menu in Qubes OS C: gui-domain diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
GUI domain
Status: Done
Milestone
Release 4.2
Development

Successfully merging a pull request may close this issue.

A bunch of fixes to appmenus handling with GUI VM marmarek/qubes-desktop-linux-common
3 participants
@marmarek @andrewdavidwong @qubesos-bot