Add conversion between NimbleTimeInterval and the relatively new Duration API #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younata
force-pushed
the
add_NimbleTimeInterval_to_Duration
branch
from
acfcc81
to
529efe1
Compare
younata
force-pushed
the
add_NimbleTimeInterval_to_Duration
branch
from
529efe1
to
1f93d6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to easily convert between
NimbleTimeIntervaland theDurationstruct introduced last year.This does lose precision when the duration is meant to have sub-nanosecond precision. I highly doubt this will affect Nimble's use case.