Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the async variants of expect require sendable values #1071

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Make the async variants of expect require sendable values #1071

merged 1 commit into from
Jul 29, 2023

Conversation

younata
Copy link
Member

@younata younata commented Jul 29, 2023

Now, when you call expect { await someThing() }... or expecta(...), the closure/autoclosure not only needs to be sendable itself, but it also needs to return a sendable value.

@younata younata added this to the v13.0.0 milestone Jul 29, 2023
@younata younata merged commit 9cf3e53 into nimble-13 Jul 29, 2023
12 of 13 checks passed
@younata younata deleted the async_expect_requires_sendable_value branch July 29, 2023 23:49
@younata younata mentioned this pull request Jul 29, 2023
Draft
1 task
younata added a commit that referenced this pull request Mar 17, 2024
@younata
The async variants of expect now require Sendable values (#1071)
af25cde
younata added a commit that referenced this pull request Apr 11, 2024
@younata
The async variants of expect now require Sendable values (#1071)
dda31da
younata added a commit that referenced this pull request Jun 18, 2024
@younata
The async variants of expect now require Sendable values (#1071)
6a06106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v13.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@younata