Rename Predicate to Matcher #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I couldn't think of a better name, This re-uses the name of the old Matcher API (removed since Nimble 10.0). This change is due to the 2023 Apple Platforms release renaming NSPredicate to Predicate, which causes friction for developers creating custom matchers.
|
As noted in this comment, I'm going to keep this PR open for a week in case anyone in the public has concerns. Then I'm going to merge this into main. Then I'm going to redo #1063 and #1069 and cut Nimble 13 RC from that. |
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Oct 12, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [Quick/Nimble](https://togithub.com/Quick/Nimble) | major | `from: "12.3.0"` -> `from: "13.0.0"` | --- ### Release Notes <details> <summary>Quick/Nimble (Quick/Nimble)</summary> ### [`v13.0.0`](https://togithub.com/Quick/Nimble/releases/tag/v13.0.0) [Compare Source](https://togithub.com/Quick/Nimble/compare/v12.3.0...v13.0.0) ### Highlights #### New Features - Nimble now supports Windows! (Thanks [@​brianmichel](https://togithub.com/brianmichel)!) - the `Predicate` series of APIs has been renamed to `Matcher`. There are typealiases for the older APIs to better enable migrations. These typealiases will be marked as removed in the next major version of Nimble (Nimble 14), and they will be removed entirely in Nimble 15. - Nimble now supports the DriverKit platform. #### Breaking Changes - The `Predicate` series of APIs have been renamed. - The `AsyncDefaults` struct is now marked as removed. It will be fully removed in the next major version of Nimble. - The platform-independent targets in `Nimble.xcodeproj` have now been consolidated into a single Nimble (and NimbleTests) target. #### Other Notes - No changes since [Nimble 13 RC 1](https://togithub.com/Quick/Nimble/releases/tag/v13.0.0-rc.1). ### Automated Release Notes #### What's Changed - Update release script for a more modern-ish release process by [@​younata](https://togithub.com/younata) in [Quick/Nimble#1086 - Bump cocoapods from 1.12.1 to 1.13.0 by [@​dependabot](https://togithub.com/dependabot) in [Quick/Nimble#1089 - Add Windows Support by [@​brianmichel](https://togithub.com/brianmichel) in [Quick/Nimble#1088 - Rename Predicate to Matcher by [@​younata](https://togithub.com/younata) in [Quick/Nimble#1090 - Mark the AsyncDefaults struct as removed. by [@​younata](https://togithub.com/younata) in [Quick/Nimble#1092 - Consolidate xcodeproj targets (... again). by [@​younata](https://togithub.com/younata) in [Quick/Nimble#1093 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [Quick/Nimble#1091 #### New Contributors - [@​brianmichel](https://togithub.com/brianmichel) made their first contribution in [Quick/Nimble#1088 **Full Changelog**: Quick/Nimble@v12.3.0...v13.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I couldn't think of a better name, This re-uses the name of the old Matcher API (removed since Nimble 10.0).
This change is due to the 2023 Apple Platforms release renaming NSPredicate to Predicate, which causes friction for developers creating custom matchers.
I also considered using "NimblePredicate" instead, but went with Matcher because our documentation already refers to predicates as matchers, so the idea/concept is still around.
This is a backwards compatible change, but it should still be a major version.
My current thinking is to take the non-sendable-related work from the Nimble 13 PR (consolidating the targets in the xcodeproj, marking AsyncDefaults as unavailable) and include them with this PR as Nimble 13. The work making Nimble compatible with Sendable/Swift 6 will be part of Nimble 14 (though, I'm going to name that branch
nimble_nextto account for if we need to release another major version of Nimble prior to that work being usable).visionOS support will likely be a point release on Nimble 13.
Fixes #1061
Checklist - While not every PR needs it, new features should consider this list: