Fixes for Xcode 7.3 / Swift 2.2 #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around XCTFail requiring StaticString for the file parameter which can't be generated from Objective-C. Linux builds continue to use XCTFail like before.
| @@ -35,6 +35,24 @@ class NimbleXCTestUnavailableHandler : AssertionHandler { | |||
| } | |||
| } | |||
|
|
|||
| #if _runtime(_ObjC) | |||
| /// Helper class providing access to the currently executing XCTestCase instance, if any | |||
| @objc internal class CurrentTestCaseTracker: NSObject, XCTestObservation { | |||
There was a problem hiding this comment.
Maybe make this class final since it's not meant to be subclassed?
Yeah this is fine, thank you! This makes sense! |
Closed
|
Thanks @NachoSoto and @briancroom! I'll cut a new release soon. |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Fixes for Xcode 7.3 / Swift 2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build on top of @NachoSoto's work in #243 (Sorry I'm not sure if there's a better way to do this besides opening a new PR like I am here!)
I'm essentially keeping
FileStringasStringin ObjC environments, and moving away fromXCTFail. This requires the use ofXCTestObservationCenterto track the current test case.This gets everything building on both Xcode 7.2 and 7.3, however there are a few test failures on 7.3 that seem to be due to behavior changes in the stringifiers. I'm not sure how to approach those failures and was thinking that should be dealt with separately.
@NachoSoto @ratkins could you see if this works for you?