Make Expectation.expression public #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable, I can't think of any adverse effects. |
|
Super, thanks @akashivskyy! |
|
Been a pleasure to contribute even at such a small scale 😄 |
|
It all counts 😉 |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Make Expectation.expression public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on a project where I use Quick and Nimble for behavioral DSL and SwiftCheck for property-based testing. This requires me to return test results, instead of asserting them straight in an assertion handler.
So I tried to overload
Expectation.to(_:description:)andExpectation.toNot(_:description:)so that they returnSwiftCheck.Testableand noticed that I cannot accessexpressionproperty and therefore pass it to a matcher.This pull request makes
Expectation.expressionpublic so that it is accessible outside the Nimble framework target.