Work around SR-6419 #483
Merged
Work around SR-6419 #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 17, 2017
| self?.observedNotifications.append(n) | ||
| }) | ||
| #else | ||
| self.token = self.notificationCenter.addObserver(forName: nil, object: nil, queue: nil, usingBlock: { [weak self] n in |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 130 characters (line_length)
| } | ||
| #elseif swift(>=4.0.2) || swift(>=3.2.2) | ||
| // A workaround to SR-6419. | ||
| self.token = self.notificationCenter.addObserver(forName: nil, object: nil, queue: nil, using: { [weak self] n in |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 125 characters (line_length)
|
@lvsti Could you try with this branch? |
ikesyo
force-pushed
the
SR-6419-workaround
branch
from
477e4fb
to
a0c3f66
Compare
ikesyo
commented
Nov 17, 2017
| // linux-swift gets confused by .append(n) | ||
| self?.observedNotifications.append(n) | ||
| } | ||
| #elseif swift(>=4.0.2) || swift(>=3.2.2) |
There was a problem hiding this comment.
Unfortunately we can't use #if if swift(>=x.y.z) in Swift 3.0 😞
ikesyo
force-pushed
the
SR-6419-workaround
branch
4 times, most recently
from
1db6bc4
to
7550e7e
Compare
ikesyo
force-pushed
the
SR-6419-workaround
branch
from
7550e7e
to
a62e07e
Compare
|
it ran without errors: https://travis-ci.org/lvsti/MockSix/jobs/303702207 👍 |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Work around SR-6419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.swift.org/browse/SR-6419
Should fix #481.