Update NimbleXCTestHandler.swift #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
access level for record failure, which can be used in custom AssertionHandler class
ikesyo
approved these changes
Jun 19, 2018
|
Let's get this merged 🚢 |
This was referenced Sep 3, 2018
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
Update NimbleXCTestHandler.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change access level for
recordFailure, which can be used in custom AssertionHandler class.So I want to have a custom
AssertionHandlerto do some stuff before fail the test. ( like sending some information to server )I created a
AssertionHandlerand set myNimbleAssertionHandleras that custom one. I expected to do some stuff in theAssertionHandlerfunction and then see the failure. but apperantly it doesn't fail the test and I have to do it in my customAssertionHandlerclass. So I needed to have access to some functions to useXCTFailorrecordFailurefor the test case file location.So I think we should keep the
recordFailurefunction as public then everyone wants to implement theAssertionHandlercan call the test failing stuff as well.