[7.x] Refactor matchError matcher using Predicate.define
#577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing `Predicate.fromDeprecatedClosure`.
ikesyo
changed the title
matchError matcher using Predicate.definematchError matcher using Predicate.define
sharplet
approved these changes
Jul 18, 2018
| let actualError = try actualExpression.evaluate() | ||
|
|
||
| let failureMessage = FailureMessage() | ||
| setFailureMessageForError( |
There was a problem hiding this comment.
Would it make sense for this function to become a mutating method on FailureMessage?
There was a problem hiding this comment.
FailureMessage is not a struct but a class that extends NSObject so that does not make sense. Instead, I would like to replace the function with one which returns ExpectationMessage (in a separate PR).
|
Thanks @sharplet |
Megal
pushed a commit
to Megal/Nimble
that referenced
this pull request
Jul 31, 2019
[7.x] Refactor `matchError` matcher using `Predicate.define`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
Predicate.fromDeprecatedClosure.