Stop using method swizzling for registering CurrentTestCaseTracker to XCTestObservationCenter #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesyo
force-pushed
the
avoid-method-swizzling
branch
2 times, most recently
from
7f1c973
to
0dce79d
Compare
|
@mark-anders Could you try with this branch? |
ikesyo
force-pushed
the
avoid-method-swizzling
branch
2 times, most recently
from
f5881d4
to
60d3c75
Compare
|
I confirmed that this works well 🚢 |
ikesyo
force-pushed
the
avoid-method-swizzling
branch
from
60d3c75
to
0ed8b9b
Compare
… XCTestObservationCenter The weird workaround is no longer needed in recent Xcode versions (at least Xcode 10.1 or later).
ikesyo
force-pushed
the
avoid-method-swizzling
branch
3 times, most recently
from
ddd721d
to
8fcb419
Compare
ikesyo
force-pushed
the
avoid-method-swizzling
branch
from
8fcb419
to
0d07988
Compare
|
Suffering from actions/runner-images#841. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weird workaround is no longer needed in recent Xcode versions (at least Xcode 10.1 or later).
Fixes #740, see it for the details.
refs: #278, #273, #271