Use unencoded names for selectors to improve Xcode test reports #1167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This idea is a little half baked but, a selector can be any finite UTF-8-encodable string, so why do we need to call
c99ExtendedIdentifier
? (Even:
is meaningless to the runtime.)If we omit it the transformation, the test sidebar and results views become a lot more readable:
We can also make the test console slightly prettier by overriding the undocumented
nameForLegacyLogging
property to omit the class name:Checklist - While not every PR needs it, new features should consider this list: