[Nimble] Addressed issues #30, 42, 47, 50 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 18, 2014 09:02
bryanenders
changed the title
bryanenders
changed the title
bryanenders
changed the title
|
The screenshot will need to be updated to reflect the change from exampleGroups() to spec(). |
| describe("failureMessage") { | ||
| it("says it expected the subject to be false") { | ||
| let message = matcher.failureMessage("Antoine Roquentin") | ||
| expect(message).to.equal("expected 'Antoine Roquentin' to be false") |
There was a problem hiding this comment.
Haha, not a showstopper or anything, but most of the other specs reference Game of Thrones 👑 ✨
|
@endersstocker Cool, I see you've already taken care of the typo! My only other comment is on I'd also merge a pull request to change the test strings to Game of Thrones references, wink wink 😉 |
added 6 commits
June 18, 2014 10:56
…-nil was redundant”
…redundant. Changed references to Game of Thrones.
|
@modocache That should do it. |
bryanenders
changed the title
| } | ||
|
|
||
| context("and is not false") { | ||
| beforeEach { subject = "Petyr Baelish" } |
|
@endersstocker Excellent! Thanks a ton! |
modocache
added a commit
that referenced
this pull request
Jun 18, 2014
[Nimble] Addressed issues #30, 42, 47, 50
This was referenced Jun 18, 2014
NachoSoto
pushed a commit
to NachoSoto/Quick
that referenced
this pull request
Jul 18, 2016
contains() for objc matches strings correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.