-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPRINT 16 #316
Merged
Merged
SPRINT 16 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update eslint; Add DELETE CO by criteria; Normalize an answer on DELETE CO for any types;
* cleanup webRTC sample: remove code for "Hack for Firefox" (https://bugzilla.mozilla.org/show_bug.cgi?id=852665) cause we are support FF52+ now * Add ability set creds and endpoint by search param in URL
The cross platform bug for bandwidth was fixed
# Conflicts: # samples/webrtc/js/app.js
Made/Proposed changes: Encode body of a request. Encode based on this https://en.wikipedia.org/wiki/Percent-encoding#Percent-encoding_reserved_characters How should this be manually tested? Run spec by jasmine; Does the documentation need an update? NO
Will WebRTC stats + bandwidth features be included into this release as well? |
…lox-javascript-sdk into dev.webrtcStats
@soulfly Yes, Vlad writing notes for this feature now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New:
Updated:
Encode body of all API requests;
Encode based on this https://en.wikipedia.org/wiki/Percent-encoding#Percent-encoding_reserved_characters;
Rework
muc.join
method:jid
orid
of a dialog;How should this be manually tested?
Run specs and check out the tab 'Network' in Chrome;
Run spec by jasmine;
Does the documentation need an update?
Yes