Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPRINT 16 #316

Merged
merged 36 commits into from
Apr 12, 2018
Merged

SPRINT 16 #316

merged 36 commits into from
Apr 12, 2018

Conversation

dimaspirit
Copy link
Contributor

@dimaspirit dimaspirit commented Mar 5, 2018

New:

  • Add header 'QB-OS' in all API requests for improving analytics;

Updated:

  • Encode body of all API requests;
    Encode based on this https://en.wikipedia.org/wiki/Percent-encoding#Percent-encoding_reserved_characters;

  • Rework muc.join method:

    • Rework putting parameters of the muc.join method. Now could pass jid or id of a dialog;
    • Now uses Node.js callbacks approach instead of a returned stanza if you pass 2 arguments to the callback function. If you pass 1 arguments you will get stanza element as before;
QB.chat.muc.join(dialogId, function(error, response) {
   if(error) {
      console.log('Error is null when all is Ok');
  }

  console.log(`response.dialogId` is always contains in response);
});
  • QB.webrtc.onCallStatsReport(session, userId, stats, error) will return new (uptaded) stats:
stats = {
    local: {
        audio: {
            bitrate: 71, // kilobits per second (kbps)
            bytesSent: 226410,
            packetsSent: 1250, 
            timestamp: 1522680935736
        },
        video: {
            frameHeight: 480,
            frameWidth: 640,
            framesPerSecond: 25.8,
            bitrate: 498,  // kilobits per second (kbps)
            bytesSent: 1438862, 
            packetsSent: 1498,
            timestamp: 1522680935736
        },
        candidate: {
            protocol: "udp"
            ip: "192.168.1.179"
            port: 51038
        }
    },
    remote: {
        audio: {
            bitrate: 47, // kilobits per second (kbps)
            bytesReceived: 148211,
            packetsReceived: 1250,
            timestamp: 1522680935736
        },
        video: {
            frameHeight: 480,
            frameWidth: 640,
            framesPerSecond: 30.4,
            bitrate: 533, // kilobits per second (kbps)
            bytesReceived: 1663716,
            packetsReceived: 1498,
            timestamp: 1522680935736
        },
        candidate: {
            protocol: "udp",
            ip: "192.168.1.179",
            port: 51908
        }
    }
}

How should this be manually tested?
Run specs and check out the tab 'Network' in Chrome;
Run spec by jasmine;

Does the documentation need an update?
Yes

@dimaspirit dimaspirit self-assigned this Mar 5, 2018
@dimaspirit dimaspirit changed the title Dev WIP - SPRINT Mar 5, 2018
@dimaspirit dimaspirit changed the title WIP - SPRINT WIP - SPRINT 16 Mar 5, 2018
@soulfly
Copy link
Contributor

soulfly commented Apr 2, 2018

Will WebRTC stats + bandwidth features be included into this release as well?

@dimaspirit
Copy link
Contributor Author

@soulfly Yes, Vlad writing notes for this feature now.

@dimaspirit dimaspirit changed the title WIP - SPRINT 16 SPRINT 16 Apr 4, 2018
@dimaspirit dimaspirit merged commit af86e55 into gh-pages Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants