Implement draft-ietf-moq-transport-04 #174
Conversation
* Unannounce * Unsubscribe * Subscribe done * Announce Cancel * Subscribe Error * Announce Error * Track Status * Track Status Request * Goaway
| std::span<const uint8_t> data) | ||
| { | ||
|
|
||
| auto td = track_delegate.lock(); |
There was a problem hiding this comment.
Should we check this isn't null, just in case?
There was a problem hiding this comment.
To that end, should we just pass a shared_ptr? Or do we not want it to be kept alive by this method?
There was a problem hiding this comment.
I think locking at the beginning and trusting it isn't nullptr is equivalent to just passing the shared_ptr by value. If we don't want the copy of the shared_ptr to share ownership, then maybe we should just pass a shared_ptr reference?
There was a problem hiding this comment.
Moq instance, at least right now, controls setting this from a shared pointer, which is guaranteed to not be null. In this sense it's known and doesn't need to be checked if null, but I suppose it wouldn't impact it if we checked if it was null or not, but it would be error if it was nullptr, which probably should result in an abort.
Implements draft-ietf-moq-transport-04 in parallel with existing
Libquicr client/server. QuicrClient/Server and MOQIntsance can be used
side by side. New
mod-exampleprogram replacesreally.