Cleanup #79
Merged
Cleanup #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhostofCookie
commented
Sep 19, 2023
RichLogan
reviewed
Sep 21, 2023
bifurcation
reviewed
Sep 21, 2023
bifurcation
approved these changes
Sep 21, 2023
| @@ -127,7 +127,7 @@ main(int argc, char* argv[]) | |||
|
|
|||
| qtransport::TransportConfig tcfg{ .tls_cert_filename = NULL, | |||
| .tls_key_filename = NULL }; | |||
| quicr::QuicRClient client(relay, tcfg, logger); | |||
| quicr::Client client(relay, tcfg, logger); | |||
There was a problem hiding this comment.
Suggested change
| quicr::Client client(relay, tcfg, logger); | |
| auto client = quicr::Client{ relay, tcfg, logger }; |
There was a problem hiding this comment.
Seems like an abuse of auto.... any particular reason for this?
Comment on lines
+94
to
+95
| const std::string& origin_url, | ||
| const std::string& auth_token) |
There was a problem hiding this comment.
Are these parameters really needed to unsubscribe? It's not like you need authorization to leave like you do to join.
There was a problem hiding this comment.
No idea. But I'm avoiding crazy API changes as much as possible for now. Would love to address this in a follow up PR though.
| { | ||
| if (!publish_namespaces.count(quicr_namespace)) | ||
| return; | ||
|
|
||
| // TODO: Need to update publish_namespaces and intent methods to support multi origin | ||
| // TODO: Support more than one publisher per ns |
There was a problem hiding this comment.
This actually seems like something we should not support, to avoid sending of duplicate names.
There was a problem hiding this comment.
Leaving this unresolved and adding @TimEvens to the conversation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big scary refactor and cleanup (the formatter was run).
Some key notes:
Build will probably fail because it relies on Quicr/qname#13 to be merged as well.