Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile on M1: fix vcpkg confusion. #12

Closed
huitema opened this issue Apr 20, 2022 · 0 comments · Fixed by #13
Closed

Compile on M1: fix vcpkg confusion. #12

huitema opened this issue Apr 20, 2022 · 0 comments · Fixed by #13

Comments

@huitema
Copy link

huitema commented Apr 20, 2022

The file CMakeList.txt includes the setting up of the "toolchain" parameter as:

 set(CMAKE_TOOLCHAIN_FILE
    ${CMAKE_CURRENT_SOURCE_DIR}/../media/vcpkg/scripts/buildsystems/vcpkg.cmake
    CACHE STRING "Vcpkg toolchain file")

This supposes that vcpkg is installed in a media folder parallel to qmedia, just like picoquic, picotls and quicrg. However, the source code include vcpkg as a submodule of qmedia. A typical installation for a submodule would be:

git submodule init
git submodule update

These commands work, but they install the code in the vspkg folder under qmedia.

The workaround was to create a symlink, media -> qmedia. But this only came after errors and head scratching.
@TimEvens TimEvens mentioned this issue Apr 22, 2022
Merged
suhasHere pushed a commit that referenced this issue Jun 16, 2022
@TimEvens @suhasHere
Minor build fixes and documentation for Apple Silicon/M1
3f29eb0 
* Adds BUILD.md to document various builds.
  Currently Apple/MacOS is documented.
* Updates FindPTLS.cmake to latest from
  picotls. Fixes #9
* Removes dav1d from vcpkg. Fixes #10
* Fix typo in decoder->DecodeFrame2
* Update publisher callback to include
  ```is_still_active``` param.
* Fix minor issue with cmake toolchain looking for
  ```media``` directory.  Fixes #12
* Fixes issue with **doctest** requiring ```TEST_ADD_LABELS```
  This can be reverted once vcpkg is updated to use latest
  doctest.  See doctest/doctest@60de223 for more details on
  fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor build fixes and documentation for Apple Silicon/M1
1 participant
@huitema