Compile on M1: need to update FindPTLS #9
Comments
|
I updated it in PR #13, but I'm wondering if we can dynamically include a common one instead of duplicating the updates per build/repo. |
|
There is a chicken and egg issue there. We cannot have it in the picotls depot, because the whole point is to find where that depot is... We could maybe place all these "finders" in a submodule that could be loaded with the "git submodule" functions. The functions in the "cmake" dir would have to reference the submodule, etc. Something like "picofinder", with a bunch of "findXXX" scripts. But where do we stop? The QUICR modules that we load are private, picoquic and picotls are public, etc. |
suhasHere
pushed a commit
that referenced
this issue
Jun 16, 2022
* Adds BUILD.md to document various builds. Currently Apple/MacOS is documented. * Updates FindPTLS.cmake to latest from picotls. Fixes #9 * Removes dav1d from vcpkg. Fixes #10 * Fix typo in decoder->DecodeFrame2 * Update publisher callback to include ```is_still_active``` param. * Fix minor issue with cmake toolchain looking for ```media``` directory. Fixes #12 * Fixes issue with **doctest** requiring ```TEST_ADD_LABELS``` This can be reverted once vcpkg is updated to use latest doctest. See doctest/doctest@60de223 for more details on fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Make on M1 breaks because the "ptls_fusion" library cannot be found. This library is only available on 64 bit X86 and ARM, not yet on M1. The dependency was fixed in the picoquic depot. The file
.../cmake/FindPTLS.cmakewas copied from the picoquic depot before the fix, and needs to be updated.The text was updated successfully, but these errors were encountered: