-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to exclude certain additions from registry sync #2
Comments
Interstingly. I have a use case for that's client side. ^^ |
@Waterpicker not sure what benefit there would be to C2S registry sync? Anyways the plan I already see is that the server may not require the client to have some registry entries |
Co-authored-by: Glitch <glitch.g3431@gmail.com>
Co-authored-by: Glitch <glitch.g3431@gmail.com>
* Add entity events module * Add TryReviveCallback based on my work in FabricMC/fabric#1394 * Add EntityTickCallback * Add AfterKilledOtherEntityCallback Based on Fabric's ServerCombatEvents.AFTER_KILLED_OTHER_ENTITY * Fix client entity tick event * Rename AfterKilledOtherEntityCallback -> EntityKilledCallback * Add entity events test mod * Add entity load/unload events. * Add ServerEntityWorldChangeEvents Direct port of @i509VCB's ones for Fabric * Apply javadoc changes * Split TryReviveCallback into two callback interfaces * Fix entity library requiring wrong loader * Update entity events to 1.18 * Remove entity tick event, to be split into its own PR * Split entity load events sidedly * Rename ServerEntityWorldChangeEvents -> EntityWorldChangeEvents * Add note about getRecentDamageSource() to EntityKilledCallback * Fix license headers for entity events * Split off client entity load events into new class * Rename methods for entity load events on client * Add ServerPlayerEntityCopyCallback * Add license to ServerPlayerEntityCopyCallback * ArrayEvent -> Event * Make a few renames * Rename entity-events -> entity_events * Use new way of declaring deps in entity_events module * Change package of entity events module * Fix entity events metadata * Switch entity events test mod to new entrypoints * Use var in enhanced-for loops in entity events * Make entity events aware listeners * Fix licenses. * Apply @TheGlitch76 javadoc suggestion #1 Co-authored-by: Glitch <glitch.g3431@gmail.com> * Apply @TheGlitch76 javadoc suggestion #2 Co-authored-by: Glitch <glitch.g3431@gmail.com> * Apply @TheGlitch76 javadoc suggestion #3 Co-authored-by: Glitch <glitch.g3431@gmail.com> * Fix entity events qmj * Replace EntityKilledCallback with LivingEntityDeathCallback * Implement @TropheusJ's suggestions * Fix TeleportCommand mixin localcapture * Remove version from entity events build.gradle * Fix entity events for 1.19 * Apply licenses to entity events * Fix checkstyle in entity events * Replace fabric.mod.json with quilt.mod.json in entity events testmod * Fix javadoc in entity events * Update library/entity/entity_events/src/main/java/org/quiltmc/qsl/entity_events/api/ServerPlayerEntityCopyCallback.java Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com> * Update library/entity/entity_events/src/main/java/org/quiltmc/qsl/entity_events/api/LivingEntityDeathCallback.java Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com> * Rename some entity world change events * Update library/entity/entity_events/src/main/java/org/quiltmc/qsl/entity_events/api/EntityReviveEvents.java Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com> * Update library/entity/entity_events/src/main/java/org/quiltmc/qsl/entity_events/api/EntityWorldChangeEvents.java Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com> * Update library/entity/entity_events/src/main/java/org/quiltmc/qsl/entity_events/api/EntityWorldChangeEvents.java Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com> * Update library/entity/entity_events/src/main/java/org/quiltmc/qsl/entity_events/api/EntityReviveEvents.java Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com> * Update library/entity/entity_events/src/main/java/org/quiltmc/qsl/entity_events/api/EntityWorldChangeEvents.java Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com> * Update library/entity/entity_events/src/main/java/org/quiltmc/qsl/entity_events/api/EntityReviveEvents.java Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com> Co-authored-by: LambdAurora <email@lambdaurora.dev> Co-authored-by: Glitch <glitch.g3431@gmail.com> Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com>
Oh dear, this is a quite ancient issue; I believe that Quilt Registry Sync has addressed this with the addition of optional entries/registries, as well as the possibility of skipping entries |
(Following up the #1.)
As stated there, having "forced" registry sync (like with Forge if I understood correctly) would mean that players with vanilla clients can't connect to a server if it has modded registries (contains new blocks, items, entites, etc.). This is fine in most use cases, but with some mods, it would be beneficial to mark certain additions in registry as "not needed on client".
Use cases?
It's the server-side mods that would benefit from that, as they can add new items / entites / etc. with unique abilities but show them as vanilla items / entities on clients.
The text was updated successfully, but these errors were encountered: