Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplication bug with furnace inputs and recipe remainders #251

Closed
ramidzkh opened this issue Jan 21, 2023 · 2 comments · Fixed by #366
Closed

Duplication bug with furnace inputs and recipe remainders #251

ramidzkh opened this issue Jan 21, 2023 · 2 comments · Fixed by #366
Assignees
@OroArmor
Labels
bug Something isn't working help wanted Extra attention is needed library: item Related to the item library.

Comments

@ramidzkh
Copy link

QSL's recipe remainder hooks add remainder support to furnace inputs; this breaks smelting recipes that use water buckets as inputs - vanilla does not compute the remainder there, so the bucket should be destroyed. Quilt adds a remainder bucket instead, causing a duplication bug with MI.

https://github.com/AztechMC/Modern-Industrialization/blob/2f46d55691c1381b206adaefd1b91d794bf91918/src/main/resources/data/modern_industrialization/recipes/vanilla_recipes/steam_bucket.json
@OroArmor OroArmor self-assigned this Jan 21, 2023
@OroArmor OroArmor added bug Something isn't working help wanted Extra attention is needed library: item Related to the item library. labels Jan 21, 2023
@OroArmor
Copy link
Member

With the new ways to read recipes in 1.20.2, I think there is a fairly simple way of doing this with a simple optional added field to the json at the end that allows disabling the remainder(s) in the recipe.

@OroArmor
Copy link
Member

I have thought of a better solution. A fix will come soon.

OroArmor added a commit to OroArmor/quilt-standard-libraries that referenced this issue Mar 30, 2024
@OroArmor
Initial Fix
782dcb0 
Fixes QuiltMC#251
@OroArmor OroArmor mentioned this issue Mar 30, 2024
Merged
OroArmor added a commit that referenced this issue Apr 2, 2024
@OroArmor
Fix Recipe Remainder API (#366)
6a7a5f7 
* Initial Fix

Fixes #251

* Add a way to get locations with the ID

* Support more default and an all location
OroArmor added a commit that referenced this issue Apr 3, 2024
@OroArmor
Fix Recipe Remainder API (#366)
2f729d5 
* Initial Fix

Fixes #251

* Add a way to get locations with the ID

* Support more default and an all location
OroArmor added a commit that referenced this issue Apr 3, 2024
@OroArmor
Fix Recipe Remainder API (#366)
30da53b 
* Initial Fix

Fixes #251

* Add a way to get locations with the ID

* Support more default and an all location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OroArmor OroArmor

Labels
bug Something isn't working help wanted Extra attention is needed library: item Related to the item library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Recipe Remainder API OroArmor/quilt-standard-libraries
2 participants
@OroArmor @ramidzkh