Fix Recipe Remainder API #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes QuiltMC#251
LambdAurora
approved these changes
Mar 30, 2024
Platymemo
approved these changes
Mar 30, 2024
...tem/item_setting/src/main/java/org/quiltmc/qsl/item/setting/api/RecipeRemainderLocation.java
Outdated
Show resolved
Hide resolved
...tem/item_setting/src/main/java/org/quiltmc/qsl/item/setting/api/RecipeRemainderLocation.java
Outdated
Show resolved
Hide resolved
|
FCP for 2 days. |
OroArmor
added a commit
that referenced
this pull request
Apr 3, 2024
* Initial Fix Fixes #251 * Add a way to get locations with the ID * Support more default and an all location
OroArmor
added a commit
that referenced
this pull request
Apr 3, 2024
* Initial Fix Fixes #251 * Add a way to get locations with the ID * Support more default and an all location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly substantial rework of the Recipe Remainder API.
The main idea behind this change is that the vanilla recipe remainders are used in two different contexts, and only those two (Crafting and Furnace Fuel). By arbitrarily extending this to all the supported locations, mods that relied on the behavior only being used in the vanilla locations broke. A great example was smelting a water bucket into a steam bucket, and duping the bucket (#251).
This PR fixes this by forcing mods to explicitly register their remainders for different locations than the default vanilla ones. This is a breaking change to the API, but no mods will crash, only their functionality will be impacted.
This PR also fixes the remainders not working in the new smithing table and extends the system to work in both the template and base slots.
Fixes #251