Item Group API #40

OroArmor · 2021-10-11T23:23:14Z

A port of Fabric's Item Group API with enhancements to increase usability and versitility.

library/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/api/QuiltItemGroup.java

library/items/item_group/src/main/resources/fabric.mod.json

library/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/api/QuiltItemGroup.java

...ary/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/impl/CreativeGuiExtensions.java

library/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/impl/ItemGroupExtensions.java

.../src/main/java/org/quiltmc/qsl/itemgroup/impl/QuiltCreativePlayerInventoryScreenWidgets.java

library/items/item_group/src/main/resources/fabric.mod.json

...ry/items/item_group/src/testmod/java/org/quiltmc/qsl/items/itemgroup/test/ItemGroupTest.java

Co-authored-by: LambdAurora <aurora42lambda@gmail.com>

library/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/api/QuiltItemGroup.java

...ary/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/impl/CreativeGuiExtensions.java

.../src/main/java/org/quiltmc/qsl/itemgroup/impl/QuiltCreativePlayerInventoryScreenWidgets.java

...ry/items/item_group/src/main/java/org/quiltmc/qsl/itemgroup/mixin/client/ItemGroupMixin.java

# Conflicts: # settings.gradle

library/item/item_group/build.gradle

Co-authored-by: LambdAurora <aurora42lambda@gmail.com>

LambdAurora

Last review got kinda lost with the force-push.

library/item/item_group/src/main/java/org/quiltmc/qsl/itemgroup/api/QuiltItemGroup.java

library/item/item_group/src/main/java/org/quiltmc/qsl/itemgroup/impl/CreativeGuiExtensions.java

.../src/main/java/org/quiltmc/qsl/itemgroup/impl/QuiltCreativePlayerInventoryScreenWidgets.java

LambdAurora

I will start to believe that I'm blind, but, qsl_ on namespaces isn't really used in any of the already merged modules, it's quilt_ instead.

library/item/item_group/src/main/resources/fabric.mod.json

LambdAurora

Almost all good!

library/item/item_group/src/main/resources/quilt_item_group.mixin.json

library/item/item_group/src/main/resources/fabric.mod.json

ghost

The itemgroup's id is used in data-gen paths so it having a . feels wrong to me, but it is valid so looks good.

library/item/item_group/src/main/java/org/quiltmc/qsl/itemgroup/api/QuiltItemGroup.java

…p/api/QuiltItemGroup.java Co-authored-by: Juuxel <6596629+Juuxel@users.noreply.github.com>

lenrik1589 · 2022-01-12T16:37:52Z

What is the current behavior when the fixed group is selected and you change the page
it was one of FAPI flaws, it would switch from fixed groups to first group in the page
also the flawed behavior is going to the first group regardless of whether you've gone to the next or previous page, it should go to the last if you turn the page back

OroArmor · 2022-01-12T17:31:10Z

@lenrik1589 I've never seen this, but being the same base as Fabric, it probably has the same bug. Do you have an example or way to reproduce the bug that I could try out?

lenrik1589 · 2022-01-12T17:35:54Z

just make more than 2 pages and switch around while having search or survival inventory tabs open to see the first one
the second one i think is kinda self-explanatory, so, switching from the second page i would expect to be in the brewery tab (or potions?) but the menu will go to the building blocks tab, not sure if it is still an issue, but in 1.16.1 it sure was

OroArmor · 2022-01-12T17:37:52Z

Oh i understand now, that each page always goes back to the "first" group when switching pages. Not sure if I know the best way to fix this, but I can try to make something for it.

lenrik1589 · 2022-01-12T17:39:11Z

since i am back to my new laptop i will also look into how i fixed this in my mod

lenrik1589

also, i don't know if this is in the scope of the API but it would be nice to see improvements to the search tab, like block tag search and overall input handling

...group/src/main/java/org/quiltmc/qsl/itemgroup/mixin/client/CreativeInventoryScreenMixin.java

OroArmor · 2022-01-12T19:56:07Z

also, i don't know if this is in the scope of the API but it would be nice to see improvements to the search tab, like block tag search and overall input handling

While I like this idea, I feel like it has two main issues:

QSL is and API, not a feature mod, changing things like this could be confusing for users
Because item and block tags are different, and a good way to check your item tags is the search, using block tags as well could cause confusion.

TheGlitch76 · 2022-01-12T20:00:14Z

also, i don't know if this is in the scope of the API but it would be nice to see improvements to the search tab, like block tag search and overall input handling

Definitely not in scope of QSL at this time, and this feature would also require moving item groups to be a core API, or else it would be inconsistently present.

lenrik1589 · 2022-01-12T20:04:52Z

yeah, i see, it just felt that being able to search by item tags but not by block tags created inconsistent behavior in vanilla (i am working on porting what i had for 1.16.3 to 1.18.1 and it just seems that there had been questionable changes to mapping as well as game code)

OroArmor · 2022-01-17T08:58:28Z

@lenrik1589 I updated the code so that tabs are now saved per page.

lenrik1589 · 2022-01-20T08:09:41Z

oh, i didn't even think of having each tab remember what was open, it makes more sense than just setting tab to [some arbitrary position], yeah
sorry couldn't look earlier, had exam two days ago and so completely missed activity here

OroArmor · 2022-01-20T08:10:27Z

no worries!

Item Group API

ce78249

OroArmor force-pushed the item-groups branch from 68d154d to ce78249 Compare October 11, 2021 23:52

OroArmor mentioned this pull request Oct 14, 2021

Item Setting API module #18

Merged

9 tasks

i509VCB added hacktoberfest-accepted library: item Related to the item library. new: library A pull request which adds a new library. new: module A pull request which adds a new module labels Oct 19, 2021

i509VCB reviewed Oct 19, 2021

View reviewed changes

OroArmor added 2 commits October 19, 2021 14:17

i5's suggestions

83a65da

Make QuiltItemGroup final

d191d2b

LambdAurora reviewed Oct 23, 2021

View reviewed changes

Apply suggestions from @LambdAurora

e0e0415

Co-authored-by: LambdAurora <aurora42lambda@gmail.com>

OroArmor force-pushed the item-groups branch from 8cab880 to e0e0415 Compare October 23, 2021 22:12

Expand fabric.mod.json to include more information

4f3f012

OroArmor requested review from LambdAurora and i509VCB November 1, 2021 17:11

LambdAurora reviewed Nov 10, 2021

View reviewed changes

Merge remote-tracking branch 'quilt/1.17.1' into item-groups

e0a6490

# Conflicts: # settings.gradle

OroArmor force-pushed the item-groups branch from cf3a447 to e0a6490 Compare November 11, 2021 03:25

LambdAurora reviewed Nov 11, 2021

View reviewed changes

library/item/item_group/build.gradle Outdated Show resolved Hide resolved

Update library/item/item_group/build.gradle

9b12091

Co-authored-by: LambdAurora <aurora42lambda@gmail.com>

LambdAurora suggested changes Nov 11, 2021

View reviewed changes

OroArmor added 2 commits November 11, 2021 12:45

More suggestions from @LambdAurora

b165977

Merge remote-tracking branch 'origin/item-groups' into item-groups

ea0a1f4

LambdAurora approved these changes Nov 11, 2021

View reviewed changes

LambdAurora added this to In Progress in Launch Roadmap Nov 13, 2021

LambdAurora added this to the Initial release milestone Nov 13, 2021

OroArmor added 2 commits November 29, 2021 13:13

Merge remote-tracking branch 'quilt/1.17.1' into item-groups

d73dd9d

Merge remote-tracking branch 'quilt/1.18' into item-groups

884f677

OroArmor changed the base branch from 1.17.1 to 1.18 November 29, 2021 21:35

LambdAurora reviewed Dec 3, 2021

View reviewed changes

library/item/item_group/src/main/resources/fabric.mod.json Outdated Show resolved Hide resolved

TheGlitch76 mentioned this pull request Dec 4, 2021

Item Library TODO #48

Open

4 tasks

OroArmor added 3 commits January 9, 2022 17:13

Some more documentation

aba3f70

Merge remote-tracking branch 'quilt/1.18' into item-groups

2365ebf

qsl -> quilt

57813c4

Platymemo approved these changes Jan 10, 2022

View reviewed changes

LambdAurora approved these changes Jan 10, 2022

View reviewed changes

library/item/item_group/src/main/resources/quilt_item_group.mixin.json Outdated Show resolved Hide resolved

library/item/item_group/src/main/resources/fabric.mod.json Show resolved Hide resolved

Fix explicit deps and mixin java version

862f5f9

OroArmor added the final-comment-period label Jan 10, 2022

Add translation api and fix headers

49863d7

ghost approved these changes Jan 10, 2022

View reviewed changes

Juuxel approved these changes Jan 11, 2022

View reviewed changes

library/item/item_group/src/main/java/org/quiltmc/qsl/itemgroup/api/QuiltItemGroup.java Outdated Show resolved Hide resolved

Update library/item/item_group/src/main/java/org/quiltmc/qsl/itemgrou…

9171779

…p/api/QuiltItemGroup.java Co-authored-by: Juuxel <6596629+Juuxel@users.noreply.github.com>

lenrik1589 suggested changes Jan 12, 2022

View reviewed changes

...group/src/main/java/org/quiltmc/qsl/itemgroup/mixin/client/CreativeInventoryScreenMixin.java Outdated Show resolved Hide resolved

...group/src/main/java/org/quiltmc/qsl/itemgroup/mixin/client/CreativeInventoryScreenMixin.java Show resolved Hide resolved

Have each page remember what the selected tab was

5e43e14

OroArmor requested a review from TheGlitch76 January 18, 2022 19:03

LambdAurora merged commit 41873f8 into QuiltMC:1.18 Jan 22, 2022

OroArmor deleted the item-groups branch January 26, 2022 18:10

OroArmor moved this from In Progress to Done in Launch Roadmap Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Item Group API #40

Item Group API #40

OroArmor commented Oct 11, 2021 •

edited

Loading

LambdAurora left a comment

LambdAurora left a comment •

edited

Loading

LambdAurora left a comment

ghost left a comment

lenrik1589 commented Jan 12, 2022

OroArmor commented Jan 12, 2022

lenrik1589 commented Jan 12, 2022

OroArmor commented Jan 12, 2022

lenrik1589 commented Jan 12, 2022

lenrik1589 left a comment

OroArmor commented Jan 12, 2022 •

edited

Loading

TheGlitch76 commented Jan 12, 2022

lenrik1589 commented Jan 12, 2022

OroArmor commented Jan 17, 2022

lenrik1589 commented Jan 20, 2022

OroArmor commented Jan 20, 2022

Item Group API #40

Item Group API #40

Conversation

OroArmor commented Oct 11, 2021 • edited Loading

LambdAurora left a comment

Choose a reason for hiding this comment

LambdAurora left a comment • edited Loading

Choose a reason for hiding this comment

LambdAurora left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

lenrik1589 commented Jan 12, 2022

OroArmor commented Jan 12, 2022

lenrik1589 commented Jan 12, 2022

OroArmor commented Jan 12, 2022

lenrik1589 commented Jan 12, 2022

lenrik1589 left a comment

Choose a reason for hiding this comment

OroArmor commented Jan 12, 2022 • edited Loading

TheGlitch76 commented Jan 12, 2022

lenrik1589 commented Jan 12, 2022

OroArmor commented Jan 17, 2022

lenrik1589 commented Jan 20, 2022

OroArmor commented Jan 20, 2022

OroArmor commented Oct 11, 2021 •

edited

Loading

LambdAurora left a comment •

edited

Loading

OroArmor commented Jan 12, 2022 •

edited

Loading