Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync 1.19.2 to 0.77.0 #141

Merged
merged 23 commits into from Feb 19, 2024
Merged

Sync 1.19.2 to 0.77.0 #141

merged 23 commits into from Feb 19, 2024

Conversation

unilock
Copy link

@unilock unilock commented Dec 10, 2023

Everything seems to be OK in a production environment with over 500 mods :)

(hopefully I did this right)

PepperCode1 and others added 22 commits February 23, 2023 10:22
* Apply disabled shade from vanilla quads directly to material

- Remove QuadViewImpl.shade

* Fix enhanced AO calculation and respect non-terrain culling state

- Fix AoCalculator using AO face data computed with a potentially different shade state
- Move non-cached computation code to separate method in AoCalculator
- Turn AoCalculator's brightnessFunc and aoFunc into abstract methods
- Do not check null check world in non-terrain AO calculation since it cannot be null
- Pass through lightFace and shade state as method arguments in AoCalculator methods to prevent additional lookups
- Do not check for the axis aligned flag in AbstractQuadRenderer.shadeFlatQuad
- Respect cull parameter passed to non-terrain rendering by merging TerrainBlockRenderInfo into BlockRenderInfo
- Use reusable search pos when calling Block.shouldDrawSide to prevent additional BlockPos allocation
- Change BlockRenderContext.render and TerrainRenderContext.tessellateBlock to return void since return value is no longer used
- Remove QuadViewImpl.vertexStart since it is unused

* Add suggestions

- Mark Direction parameter to BlockRenderInfo.shouldDrawFace as Nullable
- Reuse MaterialFinder in FrameBakedModel

(cherry picked from commit 3a95925)
(cherry picked from commit 09aba06)
* add windswept biome tag

* change windswept tag to windswept hills

* list out biomes and revert name change

(cherry picked from commit 1b66477)
(cherry picked from commit 348a9c6)

(cherry picked from commit f1c68e5)
* Birch Forest Tag FabricMC#2330

* Fix FabricMC#2649

* Run datagen

(cherry picked from commit 315602f)
(cherry picked from commit 521b5c5)
(cherry picked from commit 36d2fcc)
(cherry picked from commit 8368a8b)
* Update ko_kr.json

* fix typo

(cherry picked from commit 930b8d4)
(cherry picked from commit eeb6cf3)
(cherry picked from commit 9af20fd)
(cherry picked from commit 93582b9)
* Add registry for core shaders in custom namespaces (FabricMC#2901)

* Add registry for core shaders in custom namespaces

* Apply suggestions from code review

Co-authored-by: modmuss50 <modmuss50@gmail.com>

* Use Identifier.NAMESPACE_SEPARATOR instead of ":"

* Remove fabric_ prefixes from mixins

* Move test rendering to lower-right corner for test screenshots

---------

Co-authored-by: modmuss50 <modmuss50@gmail.com>

* Reorder imports to comply with checkstyle

* Rename some classes

---------

Co-authored-by: Juuz <6596629+Juuxel@users.noreply.github.com>
Co-authored-by: modmuss50 <modmuss50@gmail.com>
…C#3146) (FabricMC#3433)

- Adds an event, `ParticleRenderEvents.ALLOW_BLOCK_DUST_TINT`, that checks
  if a block dust particle of a specific block can be tinted.
- Bumps Fabric Loader requirement of fabric-particles-v1 to latest to
  disable Loader's mixin compatibility mode that ignores slices for
  certain At annotations.

Signed-off-by: modmuss50 <modmuss50@gmail.com>
(cherry picked from commit 86d4888)

Co-authored-by: Juuz <6596629+juuxel@users.noreply.github.com>
I will manually upload this.
# Conflicts:
#	.github/workflows/release.yml
#	fabric-networking-api-v1/src/main/java/net/fabricmc/fabric/mixin/networking/ClientConnectionMixin.java
#	fabric-particles-v1/build.gradle
#	fabric-particles-v1/src/main/resources/fabric.mod.json
#	fabric-rendering-v1/src/client/resources/quilted_fabric_rendering_v1.mixins.json
#	gradle.properties
@unilock
Copy link
Author

unilock commented Dec 10, 2023

The workflow is failing because the licenses are outdated. I wasn't sure whether I should run the licenser task.

@ix0rai ix0rai self-requested a review December 27, 2023 19:32
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just run applyLicenses and it'll all be fixed for you!

@unilock
Copy link
Author

unilock commented Dec 30, 2023

I wonder if it would be better to wait three days, so it doesn't fail again next year :v

Signed-off-by: unilock <unilock@fennet.rentals>
@OroArmor
Copy link
Member

The license change seems wrong but i dont want to fight the old licenser so ill set it go. Everything else looks good

@LDev-IX
Copy link

LDev-IX commented Feb 11, 2024

Any idea on when it will be merged?

@ix0rai
Copy link
Member

ix0rai commented Feb 19, 2024

tested, looks great!

@ix0rai ix0rai merged commit d4a161c into QuiltMC:1.19.2 Feb 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet