Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete revamp #2

Merged
merged 41 commits into from
Jan 17, 2016
Merged

Complete revamp #2

merged 41 commits into from
Jan 17, 2016

Conversation

paulbartrum
Copy link
Collaborator

Changes:

  • Support strikethrough, superscript and inline code spans.
  • Support all headings fully.
  • Support tables.
  • Better support for lists, quotes and code blocks.
  • Support backslash escape sequences.
  • 10-30x faster parsing than the old code.
  • Lots of parsing bugs fixed.

Still to do:

  • Fix nested lists (lists within lists).
  • Fix quoted lists & code blocks.

@paulbartrum paulbartrum changed the title Make (almost all) unit tests strongly typed Unit test changes + strikethrough and superscript Dec 4, 2015
@paulbartrum paulbartrum changed the title Unit test changes + strikethrough and superscript Complete revamp Jan 17, 2016
@QuinnDamerell
Copy link
Owner

Wow. This is amazing. I'm going to look it over and then I will pull it in ASAP.

I am getting this error when trying to use it in Baconit though:
Severity Code Description Project File Line Suppression State
Error Source file 'C:\Users\quinn\Repos\Baconit\UniversalMarkdown\UniversalMarkdown\Display\MarkdownTable.cs' could not be found. UniversalMarkdown C:\Users\quinn\Repos\Baconit\UniversalMarkdown\UniversalMarkdown\CSC

@QuinnDamerell
Copy link
Owner

I also seem to be having trouble opening the Universal markdown solution in VS and building it. Is there something else I have to setup to build it?

Also, just saying this again. This is amazing.

@QuinnDamerell
Copy link
Owner

I mean honestly if you want co-owner (or whatever you call it on GitHub) of this repo I am down for that. You have done amazing work here!

@QuinnDamerell
Copy link
Owner

Didn't mean to close. Sorry.

@paulbartrum
Copy link
Collaborator Author

Sorry, missed a file! It should be there now though.

@paulbartrum
Copy link
Collaborator Author

If you want to add me as a collaborator, I would be down with that :-)

QuinnDamerell added a commit that referenced this pull request Jan 17, 2016
@QuinnDamerell QuinnDamerell merged commit 36d0a32 into QuinnDamerell:master Jan 17, 2016
@QuinnDamerell
Copy link
Owner

Took a look and it all still looks amazing. Seriously great work, most likely far better than I could have ever done. I will make you a contributor, feel free to do with the project what you see fit. If there are any major refactors or anything you feel need to be done go for it. I will open some issues for things I was thinking about adding for Baconit. :)

@paulbartrum
Copy link
Collaborator Author

Thanks for the kind words, and thanks for making Baconit open source! I've been looking for a project to contribute to for a while; an application that I would actually use on a regular basis. This is the only project I've found that fits the bill so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants